Skip to content

net/sched: Better error reporting for offload failures

Ido Schimmel netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 2 repliesApplied 14/14

Patches in v1 All 14 applied

#Subject and filesSizeRepliesApplied
1/14net/sched: matchall: Take verbose flag into account when logging error messagesnet/sched/cls_matchall.c+7 -100 repliesApplied
2/14net/sched: flower: Take verbose flag into account when logging error messagesnet/sched/cls_flower.c+6 -60 repliesApplied
3/14net/sched: act_api: Add extack to offload_act_setup() callbackinclude/net/act_api.h include/net/pkt_cls.h net/sched/act_api.c +15 more+50 -270 repliesApplied
4/14net/sched: act_gact: Add extack messages for offload failureinclude/net/tc_act/tc_gact.h net/sched/act_gact.c+25 -00 repliesApplied
5/14net/sched: act_mirred: Add extack message for offload failurenet/sched/act_mirred.c+1 -00 repliesApplied
6/14net/sched: act_mpls: Add extack messages for offload failurenet/sched/act_mpls.c+7 -00 repliesApplied
7/14net/sched: act_pedit: Add extack message for offload failurenet/sched/act_pedit.c+1 -00 repliesApplied
8/14net/sched: act_police: Add extack messages for offload failurenet/sched/act_police.c+14 -30 repliesApplied
9/14net/sched: act_skbedit: Add extack messages for offload failureinclude/net/tc_act/tc_skbedit.h net/sched/act_skbedit.c+19 -00 repliesApplied
10/14net/sched: act_tunnel_key: Add extack message for offload failurenet/sched/act_tunnel_key.c+1 -00 repliesApplied
11/14net/sched: act_vlan: Add extack message for offload failurenet/sched/act_vlan.c+1 -00 repliesApplied
12/14net/sched: cls_api: Add extack message for unsupported action offloadnet/sched/cls_api.c+4 -20 repliesApplied
13/14net/sched: matchall: Avoid overwriting error messagesnet/sched/cls_matchall.c+0 -40 repliesApplied
14/14net/sched: flower: Avoid overwriting error messagesnet/sched/cls_flower.c+0 -40 repliesApplied

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPetr MachataMarcelo Ricardo Leitner
SeriesR-b
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/14] net/sched: Better error reporting for offload failures

This patchset improves error reporting to user space when offload fails during the flow action setup phase. That is, when failures occur in the actions themselves, even before calling device drivers. Requested / reported in [1].

This is done by passing extack to the offload_act_setup() callback and making use of it in the various actions.

Patches #1-#2 change matchall and flower to log error messages to user space in accordance with the verbose flag.

Patch #3 passes extack to the offload_act_setup() callback from the various call sites, including matchall and flower.

Patches #4-#11 make use of extack in the various actions to report offload failures.

Patch #12 adds an error message when the action does not support offload at all.

Patches #13-#14 change matchall and flower to stop overwriting more specific error messages.

[1] https://lore.kernel.org/netdev/20220317185249.5mff5u2x624pjewv@skbuf/

Ido Schimmel (14):
net/sched: matchall: Take verbose flag into account when logging error
messages
net/sched: flower: Take verbose flag into account when logging error
messages
net/sched: act_api: Add extack to offload_act_setup() callback net/sched: act_gact: Add extack messages for offload failure net/sched: act_mirred: Add extack message for offload failure net/sched: act_mpls: Add extack messages for offload failure net/sched: act_pedit: Add extack message for offload failure net/sched: act_police: Add extack messages for offload failure net/sched: act_skbedit: Add extack messages for offload failure net/sched: act_tunnel_key: Add extack message for offload failure net/sched: act_vlan: Add extack message for offload failure net/sched: cls_api: Add extack message for unsupported action offload net/sched: matchall: Avoid overwriting error messages net/sched: flower: Avoid overwriting error messages

 include/net/act_api.h           |  3 ++-
 include/net/pkt_cls.h           |  6 ++++--
 include/net/tc_act/tc_gact.h    | 15 +++++++++++++++
 include/net/tc_act/tc_skbedit.h | 12 ++++++++++++
 net/sched/act_api.c             |  4 ++--
 net/sched/act_csum.c            |  3 ++-
 net/sched/act_ct.c              |  3 ++-
 net/sched/act_gact.c            | 13 ++++++++++++-
 net/sched/act_gate.c            |  3 ++-
 net/sched/act_mirred.c          |  4 +++-
 net/sched/act_mpls.c            | 10 +++++++++-
 net/sched/act_pedit.c           |  4 +++-
 net/sched/act_police.c          | 20 ++++++++++++++++----
 net/sched/act_sample.c          |  3 ++-
 net/sched/act_skbedit.c         | 10 +++++++++-
 net/sched/act_tunnel_key.c      |  4 +++-
 net/sched/act_vlan.c            |  4 +++-
 net/sched/cls_api.c             | 22 ++++++++++++++--------
 net/sched/cls_flower.c          | 14 ++++++--------
 net/sched/cls_matchall.c        | 19 +++++++------------
 20 files changed, 128 insertions(+), 48 deletions(-)
Signature · 1 line
2.33.1