Skip to content

enable 4-tiled ccs modifiers on dg2

Jeevan B igt-dev 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 0 repliesNew
  2. v45 patches 0 repliesSuperseded
  3. v34 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches2 repliesSuperseded
v14 patches0 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/fourcc: Import drm_fourcc header from 9035039e1ed69include/drm-uapi/drm_fourcc.h+36 -00 replies
2/4lib/DG2: create flat ccs framebuffers with 4-tilelib/gen9_render.h lib/igt_fb.c lib/intel_aux_pgtable.c +5 more+347 -1050 replies
3/4tests/kms_ccs: Add dg2 tiled-4 ccs modifierstests/i915/kms_ccs.c+38 -240 replies
4/4tests/kms_getfb: Add flat ccs modifier supporttests/kms_getfb.c+17 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPetri LatvalaMika Kahola
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [igt-dev] [PATCH i-g-t v5 0/4] enable 4-tiled ccs modifiers on dg2

LOCAL_I915_FORMAT_MOD_4_TILED_DG2_RC_CCS work for creating framebuffers, they will pass crc checks. Copying from compressed to non-compressed for some reason will copy compressed main surface instead of decompressing.

LOCAL_I915_FORMAT_MOD_4_TILED_DG2_MC_CCS produce good image if image is framebuffer is all solid color. Areas with color edges sometimes cause random compression block size content, these blocks show at same locations but yet unknown where they're coming from. xrgb, xyuv and 16bpp yuv work equally. Planar framebuffers cause fifo underrun hence no idea if content is good or no.

v2: pull headers from kernel
v3: modified commit message

Jeevan B (1):
drm/fourcc: Import drm_fourcc header from 9035039e1ed69

Juha-Pekka Heikkilä (3):
lib/DG2: create flat ccs framebuffers with 4-tile tests/kms_ccs: Add dg2 tiled-4 ccs modifiers tests/kms_getfb: Add flat ccs modifier support

 include/drm-uapi/drm_fourcc.h |  36 ++++++++++
 lib/gen9_render.h             |  38 ++++++++---
 lib/igt_fb.c                  |  51 ++++++++++----
 lib/intel_aux_pgtable.c       |   6 +-
 lib/intel_batchbuffer.c       |   2 +-
 lib/intel_bufops.c            | 118 ++++++++++++++++++++++++++++----
 lib/intel_chipset.h           |   3 +-
 lib/rendercopy_gen9.c         | 125 +++++++++++++++++++++++-----------
 lib/veboxcopy_gen12.c         | 109 +++++++++++++++++++++--------
 tests/i915/kms_ccs.c          |  62 ++++++++++-------
 tests/kms_getfb.c             |  20 +++++-
 11 files changed, 438 insertions(+), 132 deletions(-)
Signature · 1 line
2.36.0