Skip to content

RFC ceph: convert to netfs_direct_read_iter

Jeff Layton ceph-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5netfs: don't error out on short DIO readsfs/netfs/io.c+0 -50 replies
2/5ceph: set rsize in netfs_i_context from mount optionsfs/ceph/inode.c+2 -10 replies
3/5ceph: Use the provided iterator in ceph_netfs_issue_op()fs/ceph/addr.c+4 -80 replies
4/5ceph: enhance dout messages in issue_read codepathsfs/ceph/addr.c+5 -10 replies
5/5ceph: switch to netfs_direct_read_iterfs/ceph/addr.c fs/ceph/file.c+30 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] ceph: convert to netfs_direct_read_iter

This patch is based on top of David Howells' netfs-lib branch [1]. That tree adds new O_DIRECT read helpers to netfs.ko. This patchset converts ceph to use it. With this, all of the usual xfstests pass for me on ceph.

We should be able to rip out a large part of ceph_direct_read_write with this set. I haven't done that here, and will probably wait until we have converted ceph to use netfs DIO write helpers (which don't exist yet). Once that's in place, we can just remove that function and related infrastructure wholesale.

I'd like to get this into our testing branch for an eventual merge into v5.19. We need it in our testing branch for a bit though.

David, in the past, I think we just based our master branch on top of whatever branch you were feeding to -next. Around -rc3, could you rebase netfs-lib on top of that and use that as a base for what you're feeding into -next? Then we can just base our -next feeder branch onto yours.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-lib

David Howells (1):
ceph: Use the provided iterator in ceph_netfs_issue_op()

Jeff Layton (4):
netfs: don't error out on short DIO reads
ceph: set rsize in netfs_i_context from mount options
ceph: enhance dout messages in issue_read codepaths
ceph: switch to netfs_direct_read_iter

 fs/ceph/addr.c  | 55 ++++++++++++++++++++++++++++++++-----------------
 fs/ceph/file.c  |  3 +--
 fs/ceph/inode.c |  3 ++-
 fs/netfs/io.c   |  5 -----
 4 files changed, 39 insertions(+), 27 deletions(-)
Signature · 1 line
2.35.1