Skip to content

Tidy up symbol end fixup

Ian Rogers linux-arm-kernel linux-perf-users lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v15 patches 3 repliesApplied

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf symbols: Always do architecture specific fixupstools/perf/arch/arm64/util/machine.c tools/perf/arch/powerpc/util/machine.c tools/perf/arch/s390/util/machine.c +1 more+27 -210 replies
2/4perf symbols: Add is_kernel argument to fixup endtools/perf/arch/arm64/util/machine.c tools/perf/arch/powerpc/util/machine.c tools/perf/arch/s390/util/machine.c +3 more+16 -110 replies
3/4perf symbol: By default only fix zero length symbolstools/perf/util/symbol.c+2 -10 replies
4/4perf symbols: More specific architecture end fixingtools/perf/arch/arm64/util/machine.c tools/perf/arch/powerpc/util/machine.c tools/perf/arch/s390/util/machine.c+28 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] Tidy up symbol end fixup

Fixing up more symbol ends as introduced in:
https://lore.kernel.org/lkml/[email protected]/
caused perf annotate to run into memory limits - every symbol holds all the disassembled code in the annotation, and so making symbols ends further away dramatically increased memory usage (40MB to

Quoted 1 line

1GB). Modify the symbol end logic so that special kernel cases aren't

applied in the common case.

v2. Drops a merged patch. Fixes a build issue with libbfd enabled.

Ian Rogers (4):
perf symbols: Always do architecture specific fixups perf symbols: Add is_kernel argument to fixup end perf symbol: By default only fix zero length symbols perf symbols: More specific architecture end fixing

 tools/perf/arch/arm64/util/machine.c   | 14 +++++++++-----
 tools/perf/arch/powerpc/util/machine.c | 10 +++++++---
 tools/perf/arch/s390/util/machine.c    | 12 ++++++++----
 tools/perf/util/symbol-elf.c           |  2 +-
 tools/perf/util/symbol.c               | 16 +++++++++-------
 tools/perf/util/symbol.h               |  4 ++--
 6 files changed, 36 insertions(+), 22 deletions(-)
Signature · 1 line
2.35.1.1178.g4f1659d476-goog