Add rtc refclk support for PolarFire SoC
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | dt-bindings: clk: mpfs document msspll dri registersDocumentation/ | +9 | 1 reply | |
| 2/7 | dt-bindings: clk: mpfs: add defines for two new clocksinclude/ | +4 | 0 replies | |
| 3/7 | dt-bindings: rtc: add refclk to mpfs-rtcDocumentation/ | +11 | 1 reply | |
| 4/7 | clk: microchip: mpfs: re-parent the configurable clocksdrivers/ | +132 | 0 replies | |
| 5/7 | clk: microchip: mpfs: rename sys_base to basedrivers/ | +15 | 0 replies | |
| 6/7 | clk: microchip: mpfs: add RTCREF clock controldrivers/ | +23 | 0 replies | |
| 7/7 | riscv: dts: microchip: reparent mpfs clocksarch/ arch/ | +5 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Daire McNamara |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v1 0/7] Add rtc refclk support for PolarFire SoC
Hey,
As I mentioned in my fixes for 5.18 [0], found out that the reference clock for the rtc is actually missing from the clock driver (and the dt binding).
Currently the mpfs clock driver uses a reference clock called the "msspll", set in the device tree, as the parent for the cpu/axi/ahb (config) clocks. The frequency of the msspll is determined by the FPGA bitstream & the bootloader configures the clock to match the bitstream. The real reference is provided by a 100 or 125 MHz off chip oscillator.
However, the msspll clock is not actually the parent of all clocks on the system - the reference clock for the rtc/mtimer actually has the off chip oscillator as its parent.
This series enables reading the rate of the msspll clock, converts the refclock in the device tree to the external reference & adds the missing rtc reference clock.
I assume it is okay not to add fixes tags for the rtc dt binding? Since the clock was previously missing, the binding is wrong, but idk if that qualifies as a fix?
Clock driver changes depend on the fixes I sent in [0]. Please lmk if you want me to respin into a single series w/ the fixes. Thanks,
Conor.
[0]: https://lore.kernel.org/linux-riscv/[email protected]/
Conor Dooley (7):
dt-bindings: clk: mpfs document msspll dri registers
dt-bindings: clk: mpfs: add defines for two new clocks
dt-bindings: rtc: add refclk to mpfs-rtc
clk: microchip: mpfs: re-parent the configurable clocks
clk: microchip: mpfs: rename sys_base to base
clk: microchip: mpfs: add RTCREF clock control
riscv: dts: microchip: reparent mpfs clocks
.../bindings/clock/microchip,mpfs.yaml | 11 +- .../bindings/rtc/microchip,mfps-rtc.yaml | 14 +- .../microchip/microchip-mpfs-icicle-kit.dts | 2 +- .../boot/dts/microchip/microchip-mpfs.dtsi | 8 +- drivers/clk/microchip/clk-mpfs.c | 205 +++++++++++++++--- .../dt-bindings/clock/microchip,mpfs-clock.h | 5 +- 6 files changed, 199 insertions(+), 46 deletions(-)
Signature · 1 line
2.35.1