Skip to content

minor cleanups for ice virtualization

Jacob Keller intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ice: add newline to dev_dbg in ice_vf_fdir_dump_infodrivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c+1 -12 replies
2/6ice: always check VF VSI pointer valuesdrivers/net/ethernet/intel/ice/ice_devlink.c drivers/net/ethernet/intel/ice/ice_repr.c drivers/net/ethernet/intel/ice/ice_sriov.c +3 more+77 -72 replies
2/6ice: always check VF VSI pointer values+0 -01 reply
2/6ice: always check VF VSI pointer values+0 -00 replies
3/6ice: remove return value comment for ice_reset_all_vfsdrivers/net/ethernet/intel/ice/ice_vf_lib.c+2 -20 replies
4/6ice: fix wording in comment for ice_reset_vfdrivers/net/ethernet/intel/ice/ice_vf_lib.c+2 -20 replies
5/6ice: add a function comment for ice_cfg_mac_antispoofdrivers/net/ethernet/intel/ice/ice_vf_lib.c+7 -00 replies
6/6ice: remove period on argument description in ice_for_each_vfdrivers/net/ethernet/intel/ice/ice_vf_lib.h+2 -20 replies

Reviews trailers per patch

4 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPaul MenzelKonrad Jankowski
SeriesR-b
1/6R-b
2/6R-b T-b
2/6R-b T-b
2/6R-b T-b
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [PATCH net-next 0/6] minor cleanups for ice virtualization

This series contains a few minor fix ups for virtualization files. Mainly this includes fixes for function header comments and minor wording changes.

The only larger change is a patch which adds NULL checks to ice_get_vf_vsi. This was done in order to prevent static analysis tools from complaining that a NULL value could be dereferenced. Flows where an error is not feasible have a WARN_ON check added. This change enhances the robustness of the driver by avoiding a panic in the event that a VF does not have a valid VSI.

Jacob Keller (6):
ice: add newline to dev_dbg in ice_vf_fdir_dump_info
ice: always check VF VSI pointer values
ice: remove return value comment for ice_reset_all_vfs
ice: fix wording in comment for ice_reset_vf
ice: add a function comment for ice_cfg_mac_antispoof
ice: remove period on argument description in ice_for_each_vf

 drivers/net/ethernet/intel/ice/ice_devlink.c  |  5 ++-
 drivers/net/ethernet/intel/ice/ice_repr.c     |  7 ++-
 drivers/net/ethernet/intel/ice/ice_sriov.c    | 32 ++++++++++++--
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 43 ++++++++++++++++---
 drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  4 +-
 drivers/net/ethernet/intel/ice/ice_virtchnl.c |  5 +++
 .../ethernet/intel/ice/ice_virtchnl_fdir.c    |  9 +++-
 7 files changed, 91 insertions(+), 14 deletions(-)

base-commit: c3ac33fdeac6d1a23f2d28aafaee5520632c159f

Signature · 1 line
2.35.1.456.ga9c7032d4631