Skip to content

crc16: Remove duplicate implementations

Pali Rohár u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5crc16-ccitt: Rename file with CRC-16-CCITT implementation to crc16-ccitt.cinclude/u-boot/crc.h lib/Makefile lib/crc16-ccitt.c +1 more+7 -72 replies
2/5crc16: Rename fs/ubifs/crc16.h to include/linux/crc16.hfs/ubifs/crc16.c fs/ubifs/lpt.c fs/ubifs/lpt_commit.c +1 more+3 -32 replies
3/5crc16: Move standard CRC-16 implementation from ubifs to libfs/ubifs/Makefile include/u-boot/crc.h lib/Makefile +1 more+5 -12 replies
4/5fs: ext4: Use CRC-16 implementation from linux/crc16.hfs/ext4/Makefile fs/ext4/crc16.c fs/ext4/crc16.h +2 more+6 -842 replies
5/5misc: atsha204a: Remove duplicate CRC-16 implementationdrivers/misc/Kconfig drivers/misc/atsha204a-i2c.c+4 -1192 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchStefan Roese
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] crc16: Remove duplicate implementations

This patch series removes duplicate implementations of CRC-16 with polynomial x^16 + x^15 + x^2 + 1. One implementation is enough.

Atsha 5/5 patch depends on another atsha patch:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Pali Rohár (5):
crc16-ccitt: Rename file with CRC-16-CCITT implementation to

    crc16-ccitt.c

crc16: Rename fs/ubifs/crc16.h to include/linux/crc16.h
crc16: Move standard CRC-16 implementation from ubifs to lib
fs: ext4: Use CRC-16 implementation from linux/crc16.h
misc: atsha204a: Remove duplicate CRC-16 implementation

 drivers/misc/Kconfig                |   1 +
 drivers/misc/atsha204a-i2c.c        | 122 +--------------------------
 fs/ext4/Makefile                    |   2 +-
 fs/ext4/crc16.c                     |  62 --------------
 fs/ext4/crc16.h                     |  16 ----
 fs/ext4/ext4_common.c               |   8 +-
 fs/ext4/ext4_common.h               |   2 +-
 fs/ubifs/Makefile                   |   2 +-
 fs/ubifs/crc16.c                    |  60 --------------
 fs/ubifs/lpt.c                      |   2 +-
 fs/ubifs/lpt_commit.c               |   2 +-
 {fs/ubifs => include/linux}/crc16.h |   0
 include/u-boot/crc.h                |   5 +-
 lib/Makefile                        |   7 +-
 lib/crc16-ccitt.c                   |  84 +++++++++++++++++++
 lib/crc16.c                         | 124 +++++++++++-----------------
 tools/Makefile                      |   2 +-
 17 files changed, 156 insertions(+), 345 deletions(-)
 delete mode 100644 fs/ext4/crc16.c
 delete mode 100644 fs/ext4/crc16.h
 delete mode 100644 fs/ubifs/crc16.c
 rename {fs/ubifs => include/linux}/crc16.h (100%)
 create mode 100644 lib/crc16-ccitt.c
Signature · 1 line
2.20.1