Skip to content

: generic/020: fix MAX_ATTRVAL_SIZE values

David Disseldorp fstests 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v23 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- move _attr_get_max() helper into generic/020 and use test-local $max_attrs / $max_attrval_size variables
- minor commit message changes

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4generic/020: move MAX_ATTRS and MAX_ATTRVAL_SIZE logiccommon/attr tests/generic/020+76 -750 replies
2/4generic/020: add and use _attr_get_max()tests/generic/020+95 -830 replies
3/4generic/020: fix max_attrval_size for XFS, UDF, Btrfs and NFStests/generic/020+16 -40 replies
4/4generic/020: fix max_attrval_size output filtertests/generic/020 tests/generic/020.out+2 -20 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchDave Chinner
1/4
2/4
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4]: generic/020: fix MAX_ATTRVAL_SIZE values

MAX_ATTRVAL_SIZE provides a per-filesystem maximum xattr value length limit. There are a few problems with the current values:
- XFS, UDF and Btrfs are incorrectly hardcoded to use 64 bytes
+ This is a regression from the larger value used prior to fff4359d
+ Btrfs's should be calculated using nodesize and xattr name length
- NFS currently uses a 64K limit
+ This may be above the server's underlying failsystem limit, so use a conservative estimate instead

The changes are split into four patches to ease review, but feel free to squash as deemed necessary.

Changes since v2:
- move _attr_get_max() helper into generic/020 and use test-local $max_attrs / $max_attrval_size variables
- minor commit message changes

 common/attr           |  75 ---------------------------
 tests/generic/020     | 116 +++++++++++++++++++++++++++++++++++++++---
 tests/generic/020.out |   2 +-
 3 files changed, 109 insertions(+), 84 deletions(-)