RFC Remove some of the old libopcode based disassemblers
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | disas: Remove old libopcode s390 disassemblerMAINTAINERS disas/ disas/ +2 more | +0 | 0 replies | |
| 2/3 | disas: Remove old libopcode arm disassemblerMAINTAINERS disas.c disas/ +3 more | +0 | 0 replies | |
| 3/3 | disas: Remove old libopcode i386 disassemblerMAINTAINERS disas.c disas/ +3 more | +0 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Richard Henderson | Philippe Mathieu-Daudé |
|---|---|---|
| Series | R-b | R-b |
| 1/3 | ||
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 0/3] Remove some of the old libopcode based disassemblers
Many of the disassemblers in the disas folder are based on old versions from the GNU tools (libopcode, GDB, ...) that were still licensed under the GPL v2. The GNU tools switched to GPL v3 at one point in time, so QEMU is stuck with the old versions, i.e. these files did not see much updates for new processors anymore. But for most architectures, we're preferring the Capstone disassembler now anyway, so the old libopcode disassemblers are also hardly used anymore.
I'm not 100% sure (thus this is marked as RFC), but I think we could simply drop the old disassemblers nowadays, and hardly anybody would miss them, since we now always embed capstone as a submodule anyway. Or is there still an advantage in keeping these old files around?
This RFC series tackles with s390, arm (32-bit) and i386 ... I wanted to get some feedback first, but if we agree that these can be removed, the sparc, mips and ppc disassemblers likely can be removed, too. (I think we should keep m68k.c since Capstone does not have support for Coldfire CPUs yet).
Thomas Huth (3):
disas: Remove old libopcode s390 disassembler
disas: Remove old libopcode arm disassembler
disas: Remove old libopcode i386 disassembler
include/disas/dis-asm.h | 3 - disas.c | 3 - disas/arm.c | 4012 ----------------------- disas/i386.c | 6771 --------------------------------------- disas/s390.c | 1892 ----------- target/arm/cpu.c | 8 - target/i386/cpu.c | 1 - target/s390x/cpu.c | 1 - MAINTAINERS | 6 - disas/meson.build | 3 - 10 files changed, 12700 deletions(-) delete mode 100644 disas/arm.c delete mode 100644 disas/i386.c delete mode 100644 disas/s390.c
Signature · 1 line
2.27.0