Skip to content

Enable rk356x PCIe controller

Peter Geis linux-arm-kernel linux-devicetree linux-pci linux-rockchip lkml 9 versions – Applied

Status from this message: Applied to pci/dwc, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest5 patches 10 repliesApplied
  2. v85 patches 4 repliesSuperseded
  3. v74 patches 11 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v64 patches4 repliesSuperseded
v54 patches0 repliesSuperseded
v44 patches0 repliesSuperseded
v34 patches0 repliesSuperseded
v24 patches4 repliesSuperseded
v14 patches2 repliesSuperseded

Changes in v9 from the cover letter

- move reset_control_assert out of rockchip_pcie_resource_get
- fix various formatting mistakes
- fix a checkpatch warning

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: PCI: Remove fallback from Rockchip DesignWare bindingDocumentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml+1 -110 replies
2/5PCI: rockchip-dwc: Reset core at driver probedrivers/pci/controller/dwc/pcie-dw-rockchip.c+10 -134 replies
3/5PCI: rockchip-dwc: Add legacy interrupt supportdrivers/pci/controller/dwc/pcie-dw-rockchip.c+94 -21 reply
4/5arm64: dts: rockchip: Add rk3568 PCIe2x1 controllerarch/arm64/boot/dts/rockchip/rk356x.dtsi+52 -01 reply
5/5arm64: dts: rockchip: Enable PCIe controller on quartz64-aarch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts+34 -00 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchNicolas FrattaroliRob HerringMarc Zyngier
1/5R-b
2/5T-b
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCH v9 0/5] Enable rk356x PCIe controller

This series enables the DesignWare based PCIe controller on the rk356x series of chips. We drop the fallback to the core driver due to compatibility issues. We reset the PCIe controller at driver probe to prevent issues in the future when firmware / kexec leaves the controller in an unknown state. We add support for legacy interrupts for cards that lack MSI support (which is partially broken currently). We then add the device tree nodes to enable PCIe on the Quartz64 Model A.

Patch 1 drops the snps,dw,pcie fallback from the dt-binding Patch 2 resets the PCIe controller to prevent configuration bugs Patch 3 adds legacy interrupt support to the driver Patch 4 adds the device tree binding to the rk356x.dtsi Patch 5 enables the PCIe controller on the Quartz64-A

Changelog:
v9:
- move reset_control_assert out of rockchip_pcie_resource_get
- fix various formatting mistakes
- fix a checkpatch warning

v8:
- add core reset patch
- simplify IRQ enable/disable functions
- drop spinlock
- only enable/disable IRQ requested
- only pass the IRQ register bits used to irq functions

v7:
- drop assigned-clocks

v6:
- fix a ranges issue
- point to GIC instead of ITS

v5:
- fix incorrect series (apologies for the v4 spam)

v4:
- drop the ITS modification, poor compatibility is better than completely broken

v3:
- drop select node from dt-binding
- convert to for_each_set_bit
- convert to generic_handle_domain_irq
- drop unncessary dev_err
- reorder irq_chip items
- change to level_irq
- install the handler after initializing the domain

v2:
- Define PCIE_CLIENT_INTR_STATUS_LEGACY
- Fix PCIE_LEGACY_INT_ENABLE to only enable the RC interrupts
- Add legacy interrupt enable/disable support

Peter Geis (5):
dt-bindings: PCI: Remove fallback from Rockchip DesignWare binding
PCI: rockchip-dwc: Reset core at driver probe
PCI: rockchip-dwc: Add legacy interrupt support
arm64: dts: rockchip: Add rk3568 PCIe2x1 controller
arm64: dts: rockchip: Enable PCIe controller on quartz64-a

 .../bindings/pci/rockchip-dw-pcie.yaml        |  12 +-
 .../boot/dts/rockchip/rk3566-quartz64-a.dts   |  34 +++++
 arch/arm64/boot/dts/rockchip/rk356x.dtsi      |  52 ++++++++
 drivers/pci/controller/dwc/pcie-dw-rockchip.c | 119 +++++++++++++++---
 4 files changed, 191 insertions(+), 26 deletions(-)
Signature · 1 line
2.25.1