Skip to content

staging: r8188eu: clean up block_write() in rtw_fw.c

Michael Straube linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6staging: r8188eu: correct macro spelling mistakedrivers/staging/r8188eu/core/rtw_fw.c+2 -20 replies
2/6staging: r8188eu: rename parameter of block_write()drivers/staging/r8188eu/core/rtw_fw.c+3 -32 replies
3/6staging: r8188eu: change void parameters to u8drivers/staging/r8188eu/core/rtw_fw.c+8 -100 replies
4/6staging: r8188eu: reduce variables in block_write()drivers/staging/r8188eu/core/rtw_fw.c+18 -250 replies
5/6staging: r8188eu: remove unneeded initializationsdrivers/staging/r8188eu/core/rtw_fw.c+1 -10 replies
6/6staging: r8188eu: clean up long lines in block_write()drivers/staging/r8188eu/core/rtw_fw.c+14 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] staging: r8188eu: clean up block_write() in rtw_fw.c

This series cleans up the block_write() function in rtw_fw.c.

I wondered if removing the part that writes 8-byte blocks makes any notable difference. On my system it took about two seconds longer to init the device. So I left that as is.

Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (6):
staging: r8188eu: correct macro spelling mistake
staging: r8188eu: rename parameter of block_write()
staging: r8188eu: change void parameters to u8
staging: r8188eu: reduce variables in block_write()
staging: r8188eu: remove unneeded initializations
staging: r8188eu: clean up long lines in block_write()

 drivers/staging/r8188eu/core/rtw_fw.c | 73 ++++++++++++++-------------
 1 file changed, 37 insertions(+), 36 deletions(-)
Signature · 1 line
2.35.1