Skip to content

ndctl/namespace: Fix and improve write-infoblock

Tarun Sahu nvdimm 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 4 repliesIn review
  2. v32 patches 3 repliesSuperseded
  3. v22 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Moved the struct ns_info definition to the beginning of the block
- Initialized the buf of ns_info structure in ns_info_init
- Change the format of comment in code from "//" to "/**/"
- reword the commit message of patch 2/2

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ndctl/namespace: Fix multiple issues with write-infoblockndctl/namespace.c+177 -830 replies
2/2ndctl/namespace: Implement write-infoblock for sector mode namespacesndctl/namespace.c+54 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchShivaprasad G Bhat
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2]ndctl/namespace: Fix and improve write-infoblock

This series resolves some issues with write-infoblock command and provide support to write-infoblock for sector mode namespace

write-infoblock command has issues regarding updating the align, uuid, parent_uuid. In case of no parameter passed for it, this command used to overwrite the existing values with defaults.

In PATCH 1/2 these parameters will be set to their original values, incase, values hasn't been passed in command arguments

write-infoblock command doesn't have support for sector/BTT mode namespaces. They can be converted to fsdax, but can not be written being in sector mode.

In PATCH 2/2, It creates a functionality which write infoblock of Sector/BTT namespace. Currently only uuid, parent_uuid can be updated. In future, Support for other parameters can easily be integrated in the functionality.

---
v2:
Updated the commit message (rephrasing) in patch 1/2 Moved the ns_info struct to namespace.c from namespace.h put the results after --- to avoid long commit message

v3:
reformat the commit message to meet 100 column condition

v4:
- Moved the struct ns_info definition to the beginning of the block
- Initialized the buf of ns_info structure in ns_info_init
- Change the format of comment in code from "//" to "/**/"
- reword the commit message of patch 2/2

Tarun Sahu (2):
ndctl/namespace: Fix multiple issues with write-infoblock ndctl/namespace: Implement write-infoblock for sector mode namespaces

 ndctl/namespace.c | 314 ++++++++++++++++++++++++++++++++++------------
 1 file changed, 231 insertions(+), 83 deletions(-)
Signature · 1 line
2.35.1