staging: r8188eu: fix and clean up some firmware code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest8 patches 1 replyIn review
- v38 patches 4 repliesSuperseded
- v28 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 7 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
- Keep the in-line comments of struct rt_firmware_hdr.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | staging: r8188eu: fix struct rt_firmware_hdrdrivers/ | +1 | 0 replies | |
| 2/8 | staging: r8188eu: convert u32 fields of rt_firmware_hdr to __le32drivers/ | +3 | 0 replies | |
| 3/8 | staging: r8188eu: clean up comments in struct rt_firmware_hdrdrivers/ | +13 | 0 replies | |
| 4/8 | staging: r8188eu: rename fields of struct rt_firmware_hdrdrivers/ | +29 | 0 replies | |
| 5/8 | staging: r8188eu: use sizeof instead of hardcoded firmware header sizedrivers/ | +4 | 0 replies | |
| 6/8 | staging: r8188eu: remove variables from rtl8188e_firmware_download()drivers/ | +2 | 0 replies | |
| 7/8 | staging: r8188eu: use pr_info_once() to log the firmware versiondrivers/ | +3 | 0 replies | |
| 8/8 | staging: r8188eu: check firmware header existence before accessdrivers/ | +4 | 0 replies |
Reviews trailers per patch
None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Larry Finger |
|---|---|
| Series | A-b |
| 1/8 | |
| 2/8 | |
| 3/8 | |
| 4/8 | |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/8] staging: r8188eu: fix and clean up some firmware code
This series fixes wrong size of struct rt_firmware_hdr in the first patch and does some cleanups in rtl8188e_firmware_download() in the other patches.
Tested on x86_64 with Inter-Tech DMG-02.
v4:
- Keep the in-line comments of struct rt_firmware_hdr.
v3:
- Splitted the first patch into two separate patches.
- Added back logging the firmware version only once.
- Included the compile time check for size of rt_firmware_hdr from patch 8/8 of v2 in the patch that replaces the hardcoded size.
v2:
- Added a patch to check size of struct rt_firmware_hdr at compile time.
Michael Straube (8):
staging: r8188eu: fix struct rt_firmware_hdr
staging: r8188eu: convert u32 fields of rt_firmware_hdr to __le32
staging: r8188eu: clean up comments in struct rt_firmware_hdr
staging: r8188eu: rename fields of struct rt_firmware_hdr
staging: r8188eu: use sizeof instead of hardcoded firmware header size
staging: r8188eu: remove variables from rtl8188e_firmware_download()
staging: r8188eu: use pr_info_once() to log the firmware version
staging: r8188eu: check firmware header existence before access
drivers/staging/r8188eu/core/rtw_fw.c | 84 +++++++++++---------------- 1 file changed, 34 insertions(+), 50 deletions(-)
Signature · 1 line
2.35.1