RFC KVM: arm64: Parallelize stage 2 fault handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest17 patches 37 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | KVM: arm64: Directly read owner id field in stage2_pte_is_counted()arch/ | +6 | 0 replies | |
| 2/17 | KVM: arm64: Only read the pte once per visitarch/ arch/ arch/ +1 more | +63 | 1 reply | |
| 3/17 | KVM: arm64: Return the next table from map callbacksarch/ | +3 | 0 replies | |
| 4/17 | KVM: arm64: Protect page table traversal with RCUarch/ | +22 | 2 replies | |
| 5/17 | KVM: arm64: Take an argument to indicate parallel walkarch/ arch/ arch/ +1 more | +54 | 2 replies | |
| 6/17 | KVM: arm64: Implement break-before-make sequence for parallel walksarch/ | +146 | 8 replies | |
| 7/17 | KVM: arm64: Enlighten perm relax path about parallel walksarch/ | +15 | 0 replies | |
| 8/17 | KVM: arm64: Spin off helper for initializing table ptearch/ | +16 | 0 replies | |
| 9/17 | KVM: arm64: Tear down unlinked page tables in parallel walkarch/ | +52 | 6 replies | |
| 10/17 | KVM: arm64: Assume a table pte is already owned in post-order traversalarch/ | +16 | 2 replies | |
| 11/17 | KVM: arm64: Move MMU cache init/destroy into helpersarch/ arch/ arch/ | +14 | 0 replies | |
| 12/17 | KVM: arm64: Stuff mmu page cache in sub structarch/ arch/ | +10 | 0 replies | |
| 13/17 | KVM: arm64: Setup cache for stage2 page headersarch/ arch/ | +21 | 0 replies | |
| 14/17 | KVM: arm64: Punt last page reference to rcu callback for parallel walkarch/ arch/ arch/ | +67 | 5 replies | |
| 15/17 | KVM: arm64: Allow parallel calls to kvm_pgtable_stage2_map()arch/ arch/ arch/ +1 more | +9 | 0 replies | |
| 16/17 | KVM: arm64: Enable parallel stage 2 MMU faultsarch/ | +3 | 3 replies | |
| 17/17 | TESTONLY: KVM: arm64: Add super lazy accounting of stage 2 table pagesarch/ | +13 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 00/17] KVM: arm64: Parallelize stage 2 fault handling
Presently KVM only takes a read lock for stage 2 faults if it believes the fault can be fixed by relaxing permissions on a PTE (write unprotect for dirty logging). Otherwise, stage 2 faults grab the write lock, which predictably can pile up all the vCPUs in a sufficiently large VM.
The x86 port of KVM has what it calls the TDP MMU. Basically, it is an MMU protected by the combination of a read-write lock and RCU, allowing page walkers to traverse in parallel.
This series is strongly inspired by the mechanics of the TDP MMU, making use of RCU to protect parallel walks. Note that the TLB invalidation mechanics are a bit different between x86 and ARM, so we need to use the 'break-before-make' sequence to split/collapse a block/table mapping, respectively.
Nonetheless, using atomics on the break side allows fault handlers to acquire exclusive access to a PTE (lets just call it locked). Once the PTE lock is acquired it is then safe to assume exclusive access.
Special consideration is required when pruning the page tables in parallel. Suppose we are collapsing a table into a block. Allowing parallel faults means that a software walker could be in the middle of a lower level traversal when the table is unlinked. Table walkers that prune the paging structures must now 'lock' all descendent PTEs, effectively asserting exclusive ownership of the substructure (no other walker can install something to an already locked pte).
Additionally, for parallel walks we need to punt the freeing of table pages to the next RCU sync, as there could be multiple observers of the table until all walkers exit the RCU critical section. For this I decided to cram an rcu_head into page private data for every table page. We wind up spending a bit more on table pages now, but lazily allocating for rcu callbacks probably doesn't make a lot of sense. Not only would we need a large cache of them (think about installing a level 1 block) to wire up callbacks on all descendent tables, but we also then need to spend memory to actually free memory.
I tried to organize these patches as best I could w/o introducing intermediate breakage.
The first 5 patches are meant mostly as prepatory reworks, and, in the case of RCU a nop.
Patch 6 is quite large, but I had a hard time deciding how to change the way we link/unlink tables to use atomics without breaking things along the way.
Patch 7 probably should come before patch 6, as it informs the other read-side fault (perm relax) about when a map is in progress so it'll back off.
Patches 8-10 take care of the pruning case, actually locking the child ptes instead of simply dropping table page references along the way. Note that we cannot assume a pte points to a table/page at this point, hence the same helper is called for pre- and leaf-traversal. Guide the recursion based on what got yanked from the PTE.
Patches 11-14 wire up everything to schedule rcu callbacks on to-be-freed table pages. rcu_barrier() is called on the way out from tearing down a stage 2 page table to guarantee all memory associated with the VM has actually been cleaned up.
Patches 15-16 loop in the fault handler to the new table traversal game.
Lastly, patch 17 is a nasty bit of debugging residue to spot possible table page leaks. Please don't laugh ;-)
Smoke tested with KVM selftests + kvm_page_table_test w/ 2M hugetlb to exercise the table pruning code. Haven't done anything beyond this, sending as an RFC now to get eyes on the code.
Applies to commit fb649bda6f56 ("Merge tag 'block-5.18-2022-04-15' ofgit://git.kernel.dk/linux-block")
Oliver Upton (17):
KVM: arm64: Directly read owner id field in stage2_pte_is_counted()
KVM: arm64: Only read the pte once per visit
KVM: arm64: Return the next table from map callbacks
KVM: arm64: Protect page table traversal with RCU
KVM: arm64: Take an argument to indicate parallel walk
KVM: arm64: Implement break-before-make sequence for parallel walks
KVM: arm64: Enlighten perm relax path about parallel walks
KVM: arm64: Spin off helper for initializing table pte
KVM: arm64: Tear down unlinked page tables in parallel walk
KVM: arm64: Assume a table pte is already owned in post-order
traversal
KVM: arm64: Move MMU cache init/destroy into helpers
KVM: arm64: Stuff mmu page cache in sub struct
KVM: arm64: Setup cache for stage2 page headers
KVM: arm64: Punt last page reference to rcu callback for parallel walk
KVM: arm64: Allow parallel calls to kvm_pgtable_stage2_map()
KVM: arm64: Enable parallel stage 2 MMU faults
TESTONLY: KVM: arm64: Add super lazy accounting of stage 2 table pages
arch/arm64/include/asm/kvm_host.h | 5 +- arch/arm64/include/asm/kvm_mmu.h | 2 + arch/arm64/include/asm/kvm_pgtable.h | 14 +- arch/arm64/kvm/arm.c | 4 +- arch/arm64/kvm/hyp/nvhe/mem_protect.c | 13 +- arch/arm64/kvm/hyp/nvhe/setup.c | 13 +- arch/arm64/kvm/hyp/pgtable.c | 518 +++++++++++++++++++------- arch/arm64/kvm/mmu.c | 120 ++++-- 8 files changed, 503 insertions(+), 186 deletions(-)
Signature · 6 lines
2.36.0.rc0.470.gd361397f0d-goog _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm