Skip to content

perf tools: Tidy up symbol end fixup (v3)

Namhyung Kim linux-perf-users linux-s390 linuxppc-dev lkml 1 version Applied

Status from this message: Thanks, applied to perf/urgent.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3perf symbol: Pass is_kallsyms to symbols__fixup_end()tools/perf/util/symbol-elf.c tools/perf/util/symbol.c tools/perf/util/symbol.h+6 -52 replies
2/3perf symbol: Update symbols__fixup_end()tools/perf/util/symbol.c+25 -40 replies
3/3perf symbol: Remove arch__symbols__fixup_end()tools/perf/arch/arm64/util/machine.c tools/perf/arch/powerpc/util/Build tools/perf/arch/powerpc/util/machine.c +3 more+0 -690 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIan Rogers
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] perf tools: Tidy up symbol end fixup (v3)

Hello,

This work is a follow-up of Ian's previous one at
https://lore.kernel.org/all/[email protected]/

Fixing up more symbol ends as introduced in:
https://lore.kernel.org/lkml/[email protected]/

it caused perf annotate to run into memory limits - every symbol holds all the disassembled code in the annotation, and so making symbols ends further away dramatically increased memory usage (40MB to >1GB).

Modify the symbol end fixup logic so that special kernel cases aren't applied in the common case.

v3 changes)
* rename is_kernel to is_kallsyms
* move the logic to generic function
* remove arch-specific functions

Thanks,
Namhyung

Namhyung Kim (3):
perf symbol: Pass is_kallsyms to symbols__fixup_end() perf symbol: Update symbols__fixup_end() perf symbol: Remove arch__symbols__fixup_end()

 tools/perf/arch/arm64/util/machine.c   | 21 ---------------
 tools/perf/arch/powerpc/util/Build     |  1 -
 tools/perf/arch/powerpc/util/machine.c | 25 -----------------
 tools/perf/arch/s390/util/machine.c    | 16 -----------
 tools/perf/util/symbol-elf.c           |  2 +-
 tools/perf/util/symbol.c               | 37 +++++++++++++++++++-------
 tools/perf/util/symbol.h               |  3 +--
 7 files changed, 29 insertions(+), 76 deletions(-)
 delete mode 100644 tools/perf/arch/powerpc/util/machine.c

base-commit: 41204da4c16071be9090940b18f566832d46becc

Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog