perf tools: Tidy up symbol end fixup (v3)
Status from this message: Thanks, applied to perf/urgent.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf symbol: Pass is_kallsyms to symbols__fixup_end()tools/ tools/ tools/ | +6 | 2 replies | |
| 2/3 | perf symbol: Update symbols__fixup_end()tools/ | +25 | 0 replies | |
| 3/3 | perf symbol: Remove arch__symbols__fixup_end()tools/ tools/ tools/ +3 more | +0 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ian Rogers |
|---|---|
| Series | A-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] perf tools: Tidy up symbol end fixup (v3)
Hello,
This work is a follow-up of Ian's previous one at
https://lore.kernel.org/all/[email protected]/
Fixing up more symbol ends as introduced in:
https://lore.kernel.org/lkml/[email protected]/
it caused perf annotate to run into memory limits - every symbol holds all the disassembled code in the annotation, and so making symbols ends further away dramatically increased memory usage (40MB to >1GB).
Modify the symbol end fixup logic so that special kernel cases aren't applied in the common case.
v3 changes)
* rename is_kernel to is_kallsyms
* move the logic to generic function
* remove arch-specific functions
Thanks,
Namhyung
Namhyung Kim (3):
perf symbol: Pass is_kallsyms to symbols__fixup_end() perf symbol: Update symbols__fixup_end() perf symbol: Remove arch__symbols__fixup_end()
tools/perf/arch/arm64/util/machine.c | 21 --------------- tools/perf/arch/powerpc/util/Build | 1 - tools/perf/arch/powerpc/util/machine.c | 25 ----------------- tools/perf/arch/s390/util/machine.c | 16 ----------- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 37 +++++++++++++++++++------- tools/perf/util/symbol.h | 3 +-- 7 files changed, 29 insertions(+), 76 deletions(-) delete mode 100644 tools/perf/arch/powerpc/util/machine.c
base-commit: 41204da4c16071be9090940b18f566832d46becc
Signature · 1 line
2.36.0.rc0.470.gd361397f0d-goog