drm/dp: Introduce wait_hpd_asserted() for the DP AUX bus
Status from this message: Pushed to drm-misc-next with Dmitry's reviews.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 2 repliesApplied
- v34 patches 10 repliesSuperseded
- v24 patches 1 replySuperseded
Changes in v4 from the cover letter
- Add comment that caller powered up the panel.
- Comments now explain that we may wait longer due to debouncing.
- Mention in commit message debouncing vs. powering on timing.
- Rebased to handle the fact that the stuct moved files.
- Reorganized logic as per Dmitry's suggestion.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_auxinclude/ | +30 | 0 replies | |
| 2/4 | drm/panel-edp: Take advantage of wait_hpd_asserted() in struct drm_dp_auxdrivers/ | +23 | 0 replies | |
| 3/4 | drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct drm_dp_auxdrivers/ | +38 | 1 reply | |
| 4/4 | drm/bridge: parade-ps8640: Provide wait_hpd_asserted() in struct drm_dp_auxdrivers/ | +26 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Dmitry Baryshkov |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/4] drm/dp: Introduce wait_hpd_asserted() for the DP AUX bus
This is the 2nd four patches from my RFC series ("drm/dp: Improvements for DP AUX channel") [1]. I've broken the series in two so we can make progress on the two halves separately.
v2 of this series changes to add wait_hpd_asserted() instead of is_hpd_asserted(). This allows us to move the extra delay needed for ps8640 into the ps8640 driver itself.
The idea for this series came up during the review process of Sankeerth's series trying to add eDP for Qualcomm SoCs [2].
This _doesn't_ attempt to fix the Analogix driver. If this works out, ideally someone can post a patch up to do that.
[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]/
Changes in v4:
- Add comment that caller powered up the panel.
- Comments now explain that we may wait longer due to debouncing.
- Mention in commit message debouncing vs. powering on timing.
- Rebased to handle the fact that the stuct moved files.
- Reorganized logic as per Dmitry's suggestion.
Changes in v3:
- Don't check "hpd_asserted" boolean when unset.
- Handle errors from gpiod_get_value_cansleep() properly.
Changes in v2:
- Change is_hpd_asserted() to wait_hpd_asserted()
Douglas Anderson (4):
drm/dp: Add wait_hpd_asserted() callback to struct drm_dp_aux drm/panel-edp: Take advantage of wait_hpd_asserted() in struct
drm_dp_aux
drm/panel: atna33xc20: Take advantage of wait_hpd_asserted() in struct
drm_dp_aux
drm/bridge: parade-ps8640: Provide wait_hpd_asserted() in struct
drm_dp_aux
drivers/gpu/drm/bridge/parade-ps8640.c | 39 +++++++++----- drivers/gpu/drm/panel/panel-edp.c | 33 ++++++++---- .../gpu/drm/panel/panel-samsung-atna33xc20.c | 51 ++++++++++++++----- include/drm/display/drm_dp_helper.h | 30 +++++++++++ 4 files changed, 117 insertions(+), 36 deletions(-)
Signature · 1 line
2.36.1.476.g0c4daa206d-goog