Skip to content

adin: add support for clock output

Josua Mayer netdev 4 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 3 repliesApplied 3/3
  2. v43 patches 13 repliesSuperseded
  3. v33 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v23 patches8 repliesSuperseded

Changes in v5 from the cover letter

- removed recovered clock options

Patches in v5 All 3 applied

#Subject and filesSizeRepliesApplied
1/3dt-bindings: net: adin: document phy clock output propertiesDocumentation/devicetree/bindings/net/adi,adin.yaml+15 -02 repliesApplied
2/3net: phy: adin: add support for clock outputdrivers/net/phy/adin.c+40 -00 repliesApplied
3/3ARM: dts: imx6qdl-sr-som: update phy configuration for som revision 1.9arch/arm/boot/dts/imx6qdl-sr-som.dtsi+10 -00 repliesApplied

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKrzysztof KozlowskiJakub Kicinski
SeriesA-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] adin: add support for clock output

This patch series adds support for configuring the two clock outputs of adin 1200 and 1300 PHYs. Certain network controllers require an external reference clock which can be provided by the PHY.

One of the replies to v1 was asking why the common clock framework isn't used. Currently no PHY driver has implemented providing a clock to the network controller. Instead they rely on vendor extensions to make the appropriate configuration. For example ar8035 uses qca,clk-out-frequency - this patchset aimed to replicate the same functionality.

Finally the 125MHz free-running clock is enabled in the device-tree for SolidRun i.MX6 SoMs, to support revisions 1.9 and later, where the original phy has been replaced with an adin 1300.
To avoid introducing new warning messages during boot for SoMs before rev 1.9, the status field of the new phy node is disabled by default, and will be enabled by U-Boot on demand.

Changes since v4:
- removed recovered clock options

Changes since v3:
- fix coding style violations reported by Andrew and checkpatch
- changed type of adi,phy-output-reference-clock from flag to boolean

Changes since v2:
- set new phy node status to disabled
- fix integer-as-null-pointer compiler warning

Changes since v1:
- renamed device-tree property and changed to enum
- added device-tree property for second clock output
- implemented all bits from the clock configuration register

Josua Mayer (3):
dt-bindings: net: adin: document phy clock output properties
net: phy: adin: add support for clock output
ARM: dts: imx6qdl-sr-som: update phy configuration for som revision

    1.9
 .../devicetree/bindings/net/adi,adin.yaml     | 15 +++++++
 arch/arm/boot/dts/imx6qdl-sr-som.dtsi         | 10 +++++
 drivers/net/phy/adin.c                        | 40 +++++++++++++++++++
 3 files changed, 65 insertions(+)
Signature · 1 line
2.35.3