Skip to content

Introduce In Field Scan driver

Tony Luck linux-doc linux-patches lkml platform-driver-x86 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest12 patches 10 repliesIn review
  2. v611 patches 6 repliesSuperseded
  3. v510 patches 27 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v410 patches9 repliesSuperseded
v311 patches24 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12x86/microcode/intel: Expose collect_cpu_info_early() for IFSarch/x86/include/asm/cpu.h arch/x86/kernel/cpu/intel.c arch/x86/kernel/cpu/microcode/intel.c+57 -520 replies
2/12x86/msr-index: Define INTEGRITY_CAPABILITIES MSRarch/x86/include/asm/msr-index.h+7 -00 replies
3/12stop_machine: Add stop_core_cpuslocked() for per-core operationsinclude/linux/stop_machine.h kernel/stop_machine.c+35 -00 replies
4/12platform/x86/intel/ifs: Add stub driver for In-Field ScanMAINTAINERS drivers/platform/x86/intel/Kconfig drivers/platform/x86/intel/Makefile +3 more+73 -00 replies
5/12platform/x86/intel/ifs: Read IFS firmware imagedrivers/platform/x86/intel/ifs/Makefile drivers/platform/x86/intel/ifs/core.c drivers/platform/x86/intel/ifs/ifs.h +1 more+75 -21 reply
6/12platform/x86/intel/ifs: Check IFS Image sanitydrivers/platform/x86/intel/ifs/load.c+66 -04 replies
7/12platform/x86/intel/ifs: Authenticate and copy to secured memorydrivers/platform/x86/intel/ifs/ifs.h drivers/platform/x86/intel/ifs/load.c+226 -21 reply
8/12platform/x86/intel/ifs: Add scan test supportdrivers/platform/x86/intel/ifs/Makefile drivers/platform/x86/intel/ifs/ifs.h drivers/platform/x86/intel/ifs/runtest.c+292 -11 reply
9/12platform/x86/intel/ifs: Add IFS sysfs interfacedrivers/platform/x86/intel/ifs/Makefile drivers/platform/x86/intel/ifs/core.c drivers/platform/x86/intel/ifs/ifs.h +1 more+158 -11 reply
10/12trace: platform/x86/intel/ifs: Add trace point to track Intel IFS operationsMAINTAINERS drivers/platform/x86/intel/ifs/runtest.c include/trace/events/intel_ifs.h+47 -00 replies
11/12platform/x86/intel/ifs: add ABI documentation for IFSDocumentation/ABI/testing/sysfs-platform-intel-ifs+39 -00 replies
12/12Documentation: In-Field ScanDocumentation/x86/ifs.rst Documentation/x86/index.rst drivers/platform/x86/intel/ifs/ifs.h+113 -01 reply

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchDan WilliamsThomas GleixnerBorislav PetkovGreg Kroah-HartmanHans de GoedeSteven Rostedt (Google)
1/12R-b R-b A-b Reviewed-off-by
2/12R-b R-b Reviewed-off-by
3/12R-b
4/12R-b R-b Reviewed-off-by A-b
5/12R-b R-b Reviewed-off-by A-b
6/12R-b R-b Reviewed-off-by A-b
7/12R-b R-b Reviewed-off-by A-b
8/12R-b R-b Reviewed-off-by A-b
9/12R-b R-b Reviewed-off-by A-b
10/12R-b Reviewed-off-by A-b A-b
11/12R-b Reviewed-off-by A-b
12/12R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/12] Introduce In Field Scan driver

TL;DR this driver loads scan test files that can check whether silicon in a CPU core is still running correctly. It is expected that these tests would be run several times per day to catch problems as silicon ages.

Changes since v6

Thomas Gleixner
---------------
"struct workqueue_struct *ifs_wq; Seems to be unused."

True. Deleted.

"static bool oscan_enabled = true; What changes this?"

Code that cleared it deleted. Drop this too.

"Please add curly brackets as these are not one-line statements"

Added

cpumask_first(topology_sibling_cpumask(cpu)); Shouldn't that be cpu_smt_mask()?"

Changed (and several other places)

"take up to 200 milliseconds before it retires. 200ms per test chunk?"

Updated comment to note that 200ms is for all chunks.

"Documentation lost in the intertubes"

Dredged up the version from v3 series and changed:
1) Fixed pathnames now this is a virtual misc device instead of platform device
2) Put all the text into a "/** DOC:" comment section in ifs.h with just a "kernel-doc:: drivers/platform/x86/intel/ifs/ifs.h" in the ifs.rst file under Documentation/x86.
3) Added a "big fat warning" (in all CAPS) pointing out that a core test can take up to 200 milliseconds. So admins must take extra steps if they are running latency sensitive workloads.
4) Added note that all HT threads of a core must be online to run a test.

Tony Luck
---------
Off-by-one on retries check (#define set to 5, but tried 6 times). Fixed Fixed kerneldoc description of "integrity_cap_bit" (was missing a ":")

Jithu Joseph (7):
x86/microcode/intel: Expose collect_cpu_info_early() for IFS platform/x86/intel/ifs: Read IFS firmware image platform/x86/intel/ifs: Check IFS Image sanity platform/x86/intel/ifs: Authenticate and copy to secured memory platform/x86/intel/ifs: Add scan test support platform/x86/intel/ifs: Add IFS sysfs interface platform/x86/intel/ifs: add ABI documentation for IFS

Peter Zijlstra (1):
stop_machine: Add stop_core_cpuslocked() for per-core operations

Tony Luck (4):
x86/msr-index: Define INTEGRITY_CAPABILITIES MSR platform/x86/intel/ifs: Add stub driver for In-Field Scan
trace: platform/x86/intel/ifs: Add trace point to track Intel IFS
operations
Documentation: In-Field Scan

 .../ABI/testing/sysfs-platform-intel-ifs      |  39 +++
 Documentation/x86/ifs.rst                     |   2 +
 Documentation/x86/index.rst                   |   1 +
 MAINTAINERS                                   |   8 +
 arch/x86/include/asm/cpu.h                    |  18 ++
 arch/x86/include/asm/msr-index.h              |   7 +
 arch/x86/kernel/cpu/intel.c                   |  32 +++
 arch/x86/kernel/cpu/microcode/intel.c         |  59 +---
 drivers/platform/x86/intel/Kconfig            |   1 +
 drivers/platform/x86/intel/Makefile           |   1 +
 drivers/platform/x86/intel/ifs/Kconfig        |  13 +
 drivers/platform/x86/intel/ifs/Makefile       |   3 +
 drivers/platform/x86/intel/ifs/core.c         |  73 +++++
 drivers/platform/x86/intel/ifs/ifs.h          | 234 +++++++++++++++
 drivers/platform/x86/intel/ifs/load.c         | 266 ++++++++++++++++++
 drivers/platform/x86/intel/ifs/runtest.c      | 252 +++++++++++++++++
 drivers/platform/x86/intel/ifs/sysfs.c        | 149 ++++++++++
 include/linux/stop_machine.h                  |  16 ++
 include/trace/events/intel_ifs.h              |  41 +++
 kernel/stop_machine.c                         |  19 ++
 20 files changed, 1182 insertions(+), 52 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-platform-intel-ifs
 create mode 100644 Documentation/x86/ifs.rst
 create mode 100644 drivers/platform/x86/intel/ifs/Kconfig
 create mode 100644 drivers/platform/x86/intel/ifs/Makefile
 create mode 100644 drivers/platform/x86/intel/ifs/core.c
 create mode 100644 drivers/platform/x86/intel/ifs/ifs.h
 create mode 100644 drivers/platform/x86/intel/ifs/load.c
 create mode 100644 drivers/platform/x86/intel/ifs/runtest.c
 create mode 100644 drivers/platform/x86/intel/ifs/sysfs.c
 create mode 100644 include/trace/events/intel_ifs.h

base-commit: 672c0c5173427e6b3e2a9bbb7be51ceeec78093a

Signature · 1 line
2.35.1