Skip to content

add telemetry command for show module EEPROM

Robin Zhang dpdk-dev 7 versions – Applied

Status from this message: Applied to dpdk-next-net/main, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest5 patches 1 replyApplied
  2. v85 patches 7 repliesSuperseded
  3. v75 patches 2 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v65 patches1 replySuperseded
v55 patches2 repliesSuperseded
v45 patches0 repliesSuperseded
v35 patches2 repliesSuperseded

Changes in v9 from the cover letter

- Optimize code format and commit log

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/5ethdev: add telemetry command for module EEPROMdevtools/words-case.txt lib/ethdev/meson.build lib/ethdev/rte_ethdev.c +2 more+171 -00 replies
2/5ethdev: add common code for different SFF specslib/ethdev/meson.build lib/ethdev/sff_common.c lib/ethdev/sff_common.h+493 -00 replies
3/5ethdev: support SFF-8079 module information telemetrylib/ethdev/meson.build lib/ethdev/sff_8079.c lib/ethdev/sff_telemetry.c+405 -00 replies
4/5ethdev: support SFF-8472 module information telemetrylib/ethdev/meson.build lib/ethdev/sff_8472.c lib/ethdev/sff_telemetry.c+285 -00 replies
5/5ethdev: support SFF-8636 module information telemetrylib/ethdev/meson.build lib/ethdev/sff_8636.c lib/ethdev/sff_8636.h +1 more+1359 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchAndrew Rybchenko
SeriesSeries-acked-by
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v9 thread

Cover letter [PATCH v9 0/5] add telemetry command for show module EEPROM

Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications.

Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/QSFP28 with specs SFF-8079/ SFF-8472/SFF-8024/SFF-8636.

Afther run the /ethdev/module_eeprom command, telemetry client will show the module EEPROM information. We keep the same information content compare with Linux utility ethtool, refer to command 'ethtool -m' of ethtool v5.4.

v9:
- Optimize code format and commit log

v8:
- refine code

v7:
- remove "#include <arpa/inet.h>" in lib/ethdev/sff_8472.c

v6:
- refine code

v5:
- fix CI robot compile fail issue

v4:
- remove all printf in primary application, only show information in tememetry client
- refine codes

v3:
- split up codes into several patches for better reivew

Robin Zhang (5):
ethdev: add telemetry command for module EEPROM
ethdev: add common code for different SFF specs
ethdev: support SFF-8079 module information telemetry
ethdev: support SFF-8472 module information telemetry
ethdev: support SFF-8636 module information telemetry

 devtools/words-case.txt    |   1 +
 lib/ethdev/meson.build     |   5 +
 lib/ethdev/rte_ethdev.c    |   3 +
 lib/ethdev/sff_8079.c      | 401 +++++++++++++++++++
 lib/ethdev/sff_8472.c      | 280 ++++++++++++++
 lib/ethdev/sff_8636.c      | 764 +++++++++++++++++++++++++++++++++++++
 lib/ethdev/sff_8636.h      | 590 ++++++++++++++++++++++++++++
 lib/ethdev/sff_common.c    | 319 ++++++++++++++++
 lib/ethdev/sff_common.h    | 173 +++++++++
 lib/ethdev/sff_telemetry.c | 150 ++++++++
 lib/ethdev/sff_telemetry.h |  27 ++
 11 files changed, 2713 insertions(+)
 create mode 100644 lib/ethdev/sff_8079.c
 create mode 100644 lib/ethdev/sff_8472.c
 create mode 100644 lib/ethdev/sff_8636.c
 create mode 100644 lib/ethdev/sff_8636.h
 create mode 100644 lib/ethdev/sff_common.c
 create mode 100644 lib/ethdev/sff_common.h
 create mode 100644 lib/ethdev/sff_telemetry.c
 create mode 100644 lib/ethdev/sff_telemetry.h
Signature · 1 line
2.25.1