Skip to content

Clean up common/arch split for debugger.h

Andrew Cooper xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest6 patches 10 repliesIn review

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6x86/debugger: Remove debugger_trap_entry()xen/arch/x86/include/asm/debugger.h xen/arch/x86/traps.c+16 -603 replies
2/6x86/gdbsx: Rename debug.c to gdbsx.cxen/arch/x86/Makefile xen/arch/x86/domctl.c xen/arch/x86/gdbsx.c +2 more+26 -323 replies
3/6x86/gdbsx: Move domain_pause_for_debugger() into gdbsxxen/arch/x86/domain.c xen/arch/x86/gdbsx.c xen/arch/x86/hvm/svm/svm.c +6 more+25 -201 reply
4/6x86/gdbstub: Clean up includesxen/arch/x86/gdbstub.c xen/arch/x86/setup.c xen/arch/x86/x86_64/gdbstub.c +2 more+9 -41 reply
5/6x86/debugger: Misc cleanup prior to splittingxen/arch/x86/include/asm/debugger.h xen/common/domain.c+11 -71 reply
6/6xen: Split x86/debugger.h into common and arch specific partsxen/arch/arm/include/asm/debugger.h xen/arch/x86/include/asm/debugger.h xen/arch/x86/traps.c +4 more+20 -811 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchJulien GrallJan Beulich
1/6A-b
2/6R-b
3/6R-b
4/6A-b
5/6A-b
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] Clean up common/arch split for debugger.h

This work is primarily to prevent new architectures from needing to implement a stub debugger.h for something that is in practice only implemented on x86, and probably bitrotten into oblivion. It also resolves a lot of technical debt on the x86 side.

Andrew Cooper (3):
x86/gdbsx: Move domain_pause_for_debugger() into gdbsx x86/gdbstub: Clean up includes
x86/debugger: Misc cleanup prior to splitting

Bobby Eshleman (3):
x86/debugger: Remove debugger_trap_entry() x86/gdbsx: Rename debug.c to gdbsx.c
xen: Split x86/debugger.h into common and arch specific parts

 xen/arch/arm/include/asm/debugger.h | 15 ------
 xen/arch/x86/Makefile               |  2 +-
 xen/arch/x86/domain.c               | 14 ------
 xen/arch/x86/domctl.c               | 14 +-----
 xen/arch/x86/gdbstub.c              |  5 +-
 xen/arch/x86/{debug.c => gdbsx.c}   | 37 +++++++++------
 xen/arch/x86/hvm/svm/svm.c          |  2 +-
 xen/arch/x86/hvm/vmx/realmode.c     |  3 +-
 xen/arch/x86/hvm/vmx/vmx.c          |  2 +-
 xen/arch/x86/include/asm/debugger.h | 93 +++++--------------------------------
 xen/arch/x86/include/asm/gdbsx.h    | 19 ++++++++
 xen/arch/x86/nmi.c                  |  1 -
 xen/arch/x86/setup.c                |  1 -
 xen/arch/x86/traps.c                | 37 +++++++--------
 xen/arch/x86/x86_64/gdbstub.c       |  2 +-
 xen/common/domain.c                 |  1 -
 xen/common/gdbstub.c                |  3 +-
 xen/common/keyhandler.c             |  2 +-
 xen/common/shutdown.c               |  2 +-
 xen/drivers/char/console.c          |  2 +-
 xen/include/xen/debugger.h          | 44 ++++++++++++++++++
 xen/include/xen/gdbstub.h           |  2 +
 22 files changed, 133 insertions(+), 170 deletions(-)
 delete mode 100644 xen/arch/arm/include/asm/debugger.h
 rename xen/arch/x86/{debug.c => gdbsx.c} (87%)
 create mode 100644 xen/arch/x86/include/asm/gdbsx.h
 create mode 100644 xen/include/xen/debugger.h
Signature · 1 line
2.11.0