Skip to content

xen: simplify frontend side ring setup

Juergen Gross alsa-devel dri-devel linux-block linux-integrity linux-pci linux-scsi linux-usb lkml netdev xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest21 patches 8 repliesIn review
  2. v219 patches 10 repliesSuperseded
  3. v118 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- new patches 1 and 2, comments addressed

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21xen: update grant_table.hdrivers/xen/grant-table.c include/xen/grant_table.h include/xen/interface/grant_table.h+103 -680 replies
2/21xen/grant-table: never put a reserved grant on the free listdrivers/xen/grant-table.c+4 -00 replies
3/21xen/blkfront: switch blkfront to use INVALID_GRANT_REFdrivers/block/xen-blkfront.c+12 -141 reply
4/21xen/netfront: switch netfront to use INVALID_GRANT_REFdrivers/net/xen-netfront.c+17 -190 replies
5/21xen/scsifront: remove unused GRANT_INVALID_REF definitiondrivers/scsi/xen-scsifront.c+0 -30 replies
6/21xen/usb: switch xen-hcd to use INVALID_GRANT_REFdrivers/usb/host/xen-hcd.c+6 -80 replies
7/21xen/drm: switch xen_drm_front to use INVALID_GRANT_REFdrivers/gpu/drm/xen/xen_drm_front.h drivers/gpu/drm/xen/xen_drm_front_evtchnl.c+2 -110 replies
8/21xen/sound: switch xen_snd_front to use INVALID_GRANT_REFsound/xen/xen_snd_front_evtchnl.c sound/xen/xen_snd_front_evtchnl.h+2 -110 replies
9/21xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REFdrivers/xen/gntdev-dmabuf.c+2 -110 replies
10/21xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REFdrivers/xen/xen-front-pgdir-shbuf.c+5 -131 reply
11/21xen: update ring.hdrivers/net/xen-netfront.c include/xen/interface/io/ring.h+16 -70 replies
12/21xen/xenbus: add xenbus_setup_ring() service functiondrivers/xen/xenbus/xenbus_client.c include/xen/xenbus.h+73 -00 replies
13/21xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/block/xen-blkfront.c+8 -291 reply
14/21xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/net/xen-netfront.c+12 -410 replies
15/21xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/char/tpm/xen-tpmfront.c+3 -153 replies
16/21xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/gpu/drm/xen/xen_drm_front_evtchnl.c+11 -320 replies
17/21xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/pci/xen-pcifront.c+3 -160 replies
18/21xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/scsi/xen-scsifront.c+7 -210 replies
19/21xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring()drivers/usb/host/xen-hcd.c+15 -460 replies
20/21xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring()sound/xen/xen_snd_front_evtchnl.c+10 -340 replies
21/21xen/xenbus: eliminate xenbus_grant_ring()drivers/xen/xenbus/xenbus_client.c include/xen/xenbus.h+19 -480 replies

Reviews trailers per patch

6 of 21 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-HartmanOleksandr TyshchenkoBoris OstrovskyRoger Pau Monné
SeriesR-b T-b R-b
1/21
2/21
3/21A-b
4/21
5/21
6/21A-b
7/21
8/21
9/21
10/21R-b
11/21
12/21
13/21A-b
14/21
15/21
16/21
17/21
18/21
19/21A-b
20/21
21/21R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/21] xen: simplify frontend side ring setup

Many Xen PV frontends share similar code for setting up a ring page (allocating and granting access for the backend) and for tearing it down.

Create new service functions doing all needed steps in one go.

This requires all frontends to use a common value for an invalid grant reference in order to make the functions idempotent.

Changes in V3:
- new patches 1 and 2, comments addressed

Changes in V2:
- new patch 9 and related changes in patches 10-18

Juergen Gross (21):
xen: update grant_table.h
xen/grant-table: never put a reserved grant on the free list xen/blkfront: switch blkfront to use INVALID_GRANT_REF xen/netfront: switch netfront to use INVALID_GRANT_REF xen/scsifront: remove unused GRANT_INVALID_REF definition xen/usb: switch xen-hcd to use INVALID_GRANT_REF xen/drm: switch xen_drm_front to use INVALID_GRANT_REF xen/sound: switch xen_snd_front to use INVALID_GRANT_REF xen/dmabuf: switch gntdev-dmabuf to use INVALID_GRANT_REF xen/shbuf: switch xen-front-pgdir-shbuf to use INVALID_GRANT_REF
xen: update ring.h
xen/xenbus: add xenbus_setup_ring() service function xen/blkfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/netfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/tpmfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/drmfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/pcifront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/scsifront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/usbfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/sndfront: use xenbus_setup_ring() and xenbus_teardown_ring() xen/xenbus: eliminate xenbus_grant_ring()

 drivers/block/xen-blkfront.c                |  57 +++----
 drivers/char/tpm/xen-tpmfront.c             |  18 +--
 drivers/gpu/drm/xen/xen_drm_front.h         |   9 --
 drivers/gpu/drm/xen/xen_drm_front_evtchnl.c |  43 ++----
 drivers/net/xen-netfront.c                  |  85 ++++-------
 drivers/pci/xen-pcifront.c                  |  19 +--
 drivers/scsi/xen-scsifront.c                |  31 +---
 drivers/usb/host/xen-hcd.c                  |  65 ++------
 drivers/xen/gntdev-dmabuf.c                 |  13 +-
 drivers/xen/grant-table.c                   |  12 +-
 drivers/xen/xen-front-pgdir-shbuf.c         |  18 +--
 drivers/xen/xenbus/xenbus_client.c          |  82 +++++++---
 include/xen/grant_table.h                   |   2 -
 include/xen/interface/grant_table.h         | 161 ++++++++++++--------
 include/xen/interface/io/ring.h             |  19 ++-
 include/xen/xenbus.h                        |   4 +-
 sound/xen/xen_snd_front_evtchnl.c           |  44 ++----
 sound/xen/xen_snd_front_evtchnl.h           |   9 --
 18 files changed, 287 insertions(+), 404 deletions(-)
Signature · 1 line
2.35.3