Skip to content

drm/format-helper: Support conversion to XRGB8888

Thomas Zimmermann dri-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* use helpers for struct drm_rect (Javier)
* improve commit messages (Javier)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/format-helper: Print warning on missing format conversiondrivers/gpu/drm/drm_format_helper.c+3 -00 replies
2/3drm/format-helper: Add RGB888-to-XRGB8888 conversiondrivers/gpu/drm/drm_format_helper.c+46 -00 replies
3/3drm/format-helper: Add RGB565-to-XRGB8888 conversiondrivers/gpu/drm/drm_format_helper.c+46 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez Canillas
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] drm/format-helper: Support conversion to XRGB8888

Support conversion from RGB565 and RGB888 to XRGB8888. This enables simpledrm to work with framebuffers of such formats.

UEFI and/or Grub will usually set 32-bit output in XRGB8888 format. The issue can be reproduced by enabling simpledrm and requesting a console framebuffer of different format on the kernel command line; for example

nomodeset video=1024x768-16

or

nomodeset video=1024x768-24

Conversion helpers will do nothing in this case.

Make this work by implementing the rsp conversion helpers. Also add a warning about unsupported format conversions. The patchset should also enable odd userspace configurations, such as running Xorg with 16- or 24-bit color depth.

v2:
* use helpers for struct drm_rect (Javier)
* improve commit messages (Javier)

Thomas Zimmermann (3):
drm/format-helper: Print warning on missing format conversion drm/format-helper: Add RGB888-to-XRGB8888 conversion drm/format-helper: Add RGB565-to-XRGB8888 conversion

 drivers/gpu/drm/drm_format_helper.c | 95 +++++++++++++++++++++++++++++
 1 file changed, 95 insertions(+)

base-commit: 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24

Signature · 1 line
2.36.0