Fix bugs in memcontroller cgroup tests
Status from this message: [merged mm-stable] cgroup-account-for-memory_localevents-in-test_memcg_oom_group_leaf_events.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 13 repliesApplied 5/5
- v15 patches 11 repliesSuperseded
Changes in v2 from the cover letter
- Fixed the comment headers in test_memcg_min() and test_memcg_low() to reflect the new ordering of child cgroups in those tests.
- Fixed the comment I added in test_memcg_oom_group_leaf_events() to use /* */ for multiline comments, as is the norm according to the kernel style guide.
- Changed some of the conditional logic in test_memcg_oom_group_leaf_events() that checks for OOM event counts based on memory_localevents to be more intuitive.
Patches in v2 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | cgroups: Refactor children cgroups in memcg teststools/ | +14 | 1 reply | Applied |
| 2/5 | cgroup: Account for memory_recursiveprot in test_memcg_low()tools/ tools/ tools/ | +26 | 9 replies | Applied |
| 3/5 | cgroup: Account for memory_localevents in test_memcg_oom_group_leaf_events()tools/ | +17 | 0 replies | Applied |
| 4/5 | cgroup: Removing racy check in test_memcg_sock()tools/ | +0 | 0 replies | Applied |
| 5/5 | cgroup: Fix racy check in alloc_pagecache_max_30M() helper functiontools/ | +7 | 0 replies | Applied |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Roman Gushchin | David Vernet |
|---|---|---|
| Series | A-b | R-b R-b R-b |
| 1/5 | A-b | |
| 2/5 | A-b | |
| 3/5 | A-b | |
| 4/5 | A-b | |
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] Fix bugs in memcontroller cgroup tests
tools/testing/selftests/cgroup/test_memcontrol.c contains a set of testcases which validate expected behavior of the cgroup memory controller. Roman Gushchin recently sent out a patchset that fixed a few issues in the test. This patchset continues that effort by fixing a few more issues that were causing non-deterministic failures in the suite. With this patchset, I'm unable to reproduce any more errors after running the tests in a continuous loop for many iterations. Before, I was able to reproduce at least one of the errors fixed in this patchset with just one or two runs.
Changelog:
v2:
- Fixed the comment headers in test_memcg_min() and test_memcg_low() to reflect the new ordering of child cgroups in those tests.
- Fixed the comment I added in test_memcg_oom_group_leaf_events() to use /* */ for multiline comments, as is the norm according to the kernel style guide.
- Changed some of the conditional logic in test_memcg_oom_group_leaf_events() that checks for OOM event counts based on memory_localevents to be more intuitive.
David Vernet (5):
cgroups: Refactor children cgroups in memcg tests
cgroup: Account for memory_recursiveprot in test_memcg_low()
cgroup: Account for memory_localevents in
test_memcg_oom_group_leaf_events()
cgroup: Removing racy check in test_memcg_sock()
cgroup: Fix racy check in alloc_pagecache_max_30M() helper function
tools/testing/selftests/cgroup/cgroup_util.c | 12 +++ tools/testing/selftests/cgroup/cgroup_util.h | 1 + .../selftests/cgroup/test_memcontrol.c | 77 ++++++++++++------- 3 files changed, 64 insertions(+), 26 deletions(-)
Signature · 1 line
2.30.2