Skip to content

RFC perf intel-pt: Better support for perf record --cpu

Adrian Hunter lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest21 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21libperf evsel: Factor out perf_evsel__ioctl()tools/lib/perf/evsel.c+12 -71 reply
2/21libperf evsel: Add perf_evsel__enable_thread()tools/lib/perf/evsel.c tools/lib/perf/include/perf/evsel.h+11 -04 replies
3/21perf evlist: Use libperf functions in evlist__enable_event_idx()tools/perf/util/evlist.c+2 -420 replies
4/21perf auxtrace: Move evlist__enable_event_idx() to auxtrace.ctools/perf/util/auxtrace.c tools/perf/util/evlist.c tools/perf/util/evlist.h+10 -120 replies
5/21perf auxtrace: Do not mix up mmap idxtools/perf/util/auxtrace.c+8 -22 replies
6/21libperf evlist: Remove ->idx() per_cpu parametertools/lib/perf/evlist.c tools/lib/perf/include/internal/evlist.h tools/perf/util/evlist.c+5 -40 replies
7/21libperf evlist: Move ->idx() into mmap_per_evsel()tools/lib/perf/evlist.c+3 -60 replies
8/21libperf evlist: Add evsel as a parameter to ->idx()tools/lib/perf/evlist.c tools/lib/perf/include/internal/evlist.h tools/perf/util/evlist.c+4 -20 replies
9/21perf auxtrace: Record whether an auxtrace mmap is neededtools/perf/arch/arm/util/cs-etm.c tools/perf/arch/arm64/util/arm-spe.c tools/perf/arch/s390/util/auxtrace.c +3 more+6 -00 replies
10/21perf auxctrace: Add mmap_needed to auxtrace_mmap_paramstools/perf/util/auxtrace.c tools/perf/util/auxtrace.h tools/perf/util/evlist.c +1 more+17 -60 replies
11/21perf auxtrace: Remove auxtrace_mmap_params__set_idx() per_cpu parametertools/perf/util/auxtrace.c tools/perf/util/auxtrace.h tools/perf/util/evlist.c +1 more+6 -80 replies
12/21perf evlist: Factor out evlist__dummy_event()tools/perf/util/evlist.c+8 -20 replies
13/21perf evlist: Add evlist__add_system_wide_dummy()tools/perf/util/evlist.c tools/perf/util/evlist.h+45 -00 replies
14/21perf record: Use evlist__add_system_wide_dummy() in record__config_text_poke()tools/perf/builtin-record.c+3 -180 replies
15/21perf intel-pt: Use evlist__add_system_wide_dummy() for switch trackingtools/perf/arch/x86/util/intel-pt.c+3 -100 replies
16/21perf intel-pt: Track sideband system-wide when neededtools/perf/arch/x86/util/intel-pt.c+10 -80 replies
17/21perf tools: Allow all_cpus to be a superset of user_requested_cpustools/lib/perf/evlist.c tools/perf/builtin-record.c tools/perf/util/auxtrace.c+19 -131 reply
18/21libperf evlist: Allow mixing per-thread and per-cpu mmapstools/lib/perf/evlist.c+5 -292 replies
19/21perf stat: Add requires_cpu flag for uncoretools/lib/perf/evlist.c tools/lib/perf/include/internal/evsel.h tools/perf/builtin-stat.c +2 more+7 -62 replies
20/21perf tools: Allow system-wide events to keep their own CPUstools/lib/perf/evlist.c+5 -60 replies
21/21perf tools: Allow system-wide events to keep their own threadstools/lib/perf/evlist.c+5 -20 replies

Reviews trailers per patch

1 of 21 patches has a Reviewed-by or Acked-by.

PatchIan Rogers
1/21
2/21
3/21
4/21
5/21
6/21
7/21
8/21
9/21
10/21
11/21
12/21
13/21
14/21
15/21
16/21
17/21A-b
18/21
19/21
20/21
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 00/21] perf intel-pt: Better support for perf record --cpu

Hi

Here are patches to support capturing Intel PT sideband events such as mmap, task, context switch, text poke etc, on every CPU even when tracing selected user_requested_cpus. That is, when using the perf record -C or
--cpu option.

This is needed for:
1. text poke: a text poke on any CPU affects all CPUs
2. tracing user space: a user space process can migrate between CPUs so mmap events that happen on a different CPU can be needed to decode a user_requested_cpus CPU.

For example:

Trace on CPU 1:

perf record --kcore -C 1 -e intel_pt// &

Start a task on CPU 0:

taskset 0x1 testprog &

Migrate it to CPU 1:

taskset -p 0x2 <testprog pid>

Stop tracing:

kill %1

Prior to these changes there will be errors decoding testprog in userspace because the comm and mmap events for testprog will not have been captured.

There is quite a bit of preparation:

The first 5 patches stop auxtrace mixing up mmap idx between evlist and evsel. That is going to matter when
evlist->all_cpus != evlist->user_requested_cpus != evsel->cpus:

libperf evsel: Factor out perf_evsel__ioctl()
libperf evsel: Add perf_evsel__enable_thread()
perf evlist: Use libperf functions in evlist__enable_event_idx() perf auxtrace: Move evlist__enable_event_idx() to auxtrace.c perf auxtrace: Do not mix up mmap idx

The next 6 patches stop attempts to auxtrace mmap when it is not an auxtrace event e.g. when mmapping the CPUs on which only sideband is captured:

libperf evlist: Remove ->idx() per_cpu parameter
libperf evlist: Move ->idx() into mmap_per_evsel()
libperf evlist: Add evsel as a parameter to ->idx()
perf auxtrace: Record whether an auxtrace mmap is needed perf auxctrace: Add mmap_needed to auxtrace_mmap_params perf auxtrace: Remove auxtrace_mmap_params__set_idx() per_cpu parameter

The next 5 patches switch to setting up dummy event maps before adding the evsel so that the evsel is subject to map propagation, primarily to cause addition of the evsel's CPUs to all_cpus.

perf evlist: Factor out evlist__dummy_event()
perf evlist: Add evlist__add_system_wide_dummy()
perf record: Use evlist__add_system_wide_dummy() in record__config_text_poke() perf intel-pt: Use evlist__add_system_wide_dummy() for switch tracking perf intel-pt: Track sideband system-wide when needed

The remaining 5 patches make more significant changes.

First change from using user_requested_cpus to using all_cpus where necessary:

perf tools: Allow all_cpus to be a superset of user_requested_cpus

Secondly, mmap all per-thread and all per-cpu events:

libperf evlist: Allow mixing per-thread and per-cpu mmaps

Stop using system_wide flag for uncore because it will not work anymore:

perf stat: Add per_cpu_only flag for uncore

Finally change map propagation so that system-wide events retain their cpus and (dummy) threads:

perf tools: Allow system-wide events to keep their own CPUs perf tools: Allow system-wide events to keep their own threads

Adrian Hunter (21):
libperf evsel: Factor out perf_evsel__ioctl()
libperf evsel: Add perf_evsel__enable_thread()
perf evlist: Use libperf functions in evlist__enable_event_idx() perf auxtrace: Move evlist__enable_event_idx() to auxtrace.c perf auxtrace: Do not mix up mmap idx
libperf evlist: Remove ->idx() per_cpu parameter
libperf evlist: Move ->idx() into mmap_per_evsel()
libperf evlist: Add evsel as a parameter to ->idx()
perf auxtrace: Record whether an auxtrace mmap is needed
perf auxctrace: Add mmap_needed to auxtrace_mmap_params
perf auxtrace: Remove auxtrace_mmap_params__set_idx() per_cpu parameter perf evlist: Factor out evlist__dummy_event()
perf evlist: Add evlist__add_system_wide_dummy()
perf record: Use evlist__add_system_wide_dummy() in record__config_text_poke() perf intel-pt: Use evlist__add_system_wide_dummy() for switch tracking perf intel-pt: Track sideband system-wide when needed
perf tools: Allow all_cpus to be a superset of user_requested_cpus libperf evlist: Allow mixing per-thread and per-cpu mmaps
perf stat: Add per_cpu_only flag for uncore
perf tools: Allow system-wide events to keep their own CPUs
perf tools: Allow system-wide events to keep their own threads

 tools/lib/perf/evlist.c                  |  67 +++++++------------
 tools/lib/perf/evsel.c                   |  29 +++++++--
 tools/lib/perf/include/internal/evlist.h |   3 +-
 tools/lib/perf/include/internal/evsel.h  |   1 +
 tools/lib/perf/include/perf/evsel.h      |   1 +
 tools/perf/arch/arm/util/cs-etm.c        |   1 +
 tools/perf/arch/arm64/util/arm-spe.c     |   1 +
 tools/perf/arch/s390/util/auxtrace.c     |   1 +
 tools/perf/arch/x86/util/intel-bts.c     |   1 +
 tools/perf/arch/x86/util/intel-pt.c      |  32 ++++------
 tools/perf/builtin-record.c              |  39 +++++-------
 tools/perf/builtin-stat.c                |   5 +-
 tools/perf/util/auxtrace.c               |  31 +++++++--
 tools/perf/util/auxtrace.h               |   8 ++-
 tools/perf/util/evlist.c                 | 106 +++++++++++++++----------------
 tools/perf/util/evlist.h                 |   7 +-
 tools/perf/util/evsel.c                  |   1 +
 tools/perf/util/evsel.h                  |   1 +
 tools/perf/util/mmap.c                   |   4 +-
 tools/perf/util/parse-events.c           |   2 +-
 20 files changed, 176 insertions(+), 165 deletions(-)

Regards
Adrian