Skip to content

RFC Build Rockchip final images using binman

Andrew Abbott u-boot 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest8 patches 13 repliesIn review
  2. v1 RFC8 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Revert u-boot-rockchip-sdmmc.bin name to u-boot-rockchip.bin, to keep the name the same as before.
- Fix whitespace issues.
- Remove note from docs about different offsets in SPI flash for different SoCs - this was a bad assumption on my part, it doesn't work this way.
- Update name of SD/MMC image in the docs from u-boot-rockchip-sdmmc.bin to u-boot-rockchip.bin.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8binman: mkimage: Support ':'-separated inputstools/binman/etype/mkimage.py+21 -122 replies
2/8rockchip: Add binman definitions for final imagesarch/arm/dts/rockchip-u-boot.dtsi arch/arm/mach-rockchip/Kconfig+53 -73 replies
3/8soc: rockchip: Include common U-Boot dtsi filearch/arm/dts/rk3308-u-boot.dtsi arch/arm/dts/rk3328-u-boot.dtsi arch/arm/dts/rk3368-u-boot.dtsi +1 more+7 -01 reply
4/8board: rockchip: Move SPI U-Boot offset to configarch/arm/dts/rk3368-lion-haikou-u-boot.dtsi arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +7 more+5 -151 reply
5/8rockchip: Remove obsolete Makefile targetsMakefile+3 -280 replies
6/8rockchip: Enable binman for ARM64Kconfig arch/arm/Kconfig+3 -32 replies
7/8doc: rockchip: Update for new binman image generationdoc/board/rockchip/rockchip.rst+7 -220 replies
8/8board: rockpro64: Enable building SPI imagearch/arm/mach-rockchip/rk3399/Kconfig+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/8] Build Rockchip final images using binman

My original goal was to produce SPI images for Rockchip platforms (specifically for me, ROCKPro64, and in the future ROCK64). Looking into it, it seemed nicer to just switch the SD/MMC image generation over to binman as well in the process.

This is my attempt to move Rockchip final full image generation to binman, adding the option to make full SPI images as well.

Other questions:

- I noticed that ATF generation for ARM64 Rockchip is done via a Python script instead of binman. I don't currently know how to change that over to binman, but is that something worth pursuing as part of this?

Please give me your feedback!

Changes in v2:
- Revert u-boot-rockchip-sdmmc.bin name to u-boot-rockchip.bin, to keep the name the same as before.
- Fix whitespace issues.
- Remove note from docs about different offsets in SPI flash for different SoCs - this was a bad assumption on my part, it doesn't work this way.
- Update name of SD/MMC image in the docs from u-boot-rockchip-sdmmc.bin to u-boot-rockchip.bin.

Andrew Abbott (8):
binman: mkimage: Support ':'-separated inputs
rockchip: Add binman definitions for final images
soc: rockchip: Include common U-Boot dtsi file
board: rockchip: Move SPI U-Boot offset to config
rockchip: Remove obsolete Makefile targets
rockchip: Enable binman for ARM64
doc: rockchip: Update for new binman image generation
board: rockpro64: Enable building SPI image

 Kconfig                                      |  4 +-
 Makefile                                     | 31 ++----------
 arch/arm/Kconfig                             |  2 +-
 arch/arm/dts/rk3308-u-boot.dtsi              |  2 +
 arch/arm/dts/rk3328-u-boot.dtsi              |  2 +
 arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi  |  1 -
 arch/arm/dts/rk3368-u-boot.dtsi              |  1 +
 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi |  4 --
 arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi  |  1 -
 arch/arm/dts/rk3399-roc-pc-u-boot.dtsi       |  4 --
 arch/arm/dts/rk3399-rockpro64-u-boot.dtsi    |  4 --
 arch/arm/dts/rk3568-u-boot.dtsi              |  2 +
 arch/arm/dts/rockchip-u-boot.dtsi            | 53 ++++++++++++++++++--
 arch/arm/mach-rockchip/Kconfig               |  7 ++-
 arch/arm/mach-rockchip/rk3399/Kconfig        |  1 +
 configs/lion-rk3368_defconfig                |  1 +
 configs/pinebook-pro-rk3399_defconfig        |  1 +
 configs/puma-rk3399_defconfig                |  2 +-
 configs/roc-pc-rk3399_defconfig              |  1 +
 configs/rockpro64-rk3399_defconfig           |  1 +
 doc/board/rockchip/rockchip.rst              | 29 +++--------
 tools/binman/etype/mkimage.py                | 33 +++++++-----
 22 files changed, 100 insertions(+), 87 deletions(-)
Signature · 1 line
2.36.0