Skip to content

usb: core: acpi: Rely on the sysdev pointer

Heikki Krogerus linux-usb lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v12 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: core: acpi: Use the sysdev pointer instead of controller devicedrivers/usb/core/usb-acpi.c+5 -20 replies
2/2usb: dwc3: host: Stop setting the ACPI companiondrivers/usb/dwc3/host.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] usb: core: acpi: Rely on the sysdev pointer

Hi,

I've added a comment in the first patch explaining that the sysdev pointer is the host controller from firmware perspective like requested by Andy. But please note that I did not make any comments about the location of the sysdev ACPI companion in ACPI namespace on purpose. We don't need to, and we actually can't make any assumptions about that.

original cover letter:

Since we have that sysdev pointer, we need to use it also when assigning the ACPI companion for the root hub. That should remove the need to "manually" assign the ACPI companion to the controller device in the xhci glue drivers like dwc3-host.c.

Assigning the ACPI companion in those glue drivers is very problematic, because it screws up the fwnode->secondary pointer. But as said, since we have that sysdev pointer, there is no need to manually set it. sysdev pointer should always point to the correct physical device from firmware PoW.

thanks,

Heikki Krogerus (2):
usb: core: acpi: Use the sysdev pointer instead of controller device
usb: dwc3: host: Stop setting the ACPI companion

 drivers/usb/core/usb-acpi.c | 7 +++++--
 drivers/usb/dwc3/host.c     | 2 --
 2 files changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
2.35.1