Skip to content

ASoC: Intel: avs: Driver core and PCM operations

Cezary Rojewski alsa-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 10 repliesIn review
  2. v215 patches 4 repliesSuperseded
  3. v114 patches 25 repliesSuperseded

Changes in v3 from the cover letter

- addressed (hopefully) trace-code compilation under .configs with CONFIG_FTRACE dropped

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15ASoC: Intel: avs: Account for libraries when booting basefwsound/soc/intel/avs/avs.h sound/soc/intel/avs/loader.c+83 -00 replies
2/15ASoC: Intel: avs: Generic soc component driverinclude/sound/soc-acpi.h sound/soc/intel/avs/Makefile sound/soc/intel/avs/pcm.c+278 -10 replies
3/15ASoC: Intel: avs: Generic PCM FE operationssound/soc/intel/avs/pcm.c sound/soc/intel/avs/topology.c+338 -20 replies
4/15ASoC: Intel: avs: non-HDA PCM BE operationssound/soc/intel/avs/avs.h sound/soc/intel/avs/pcm.c+225 -10 replies
5/15ASoC: Intel: avs: HDA PCM BE operationssound/soc/intel/avs/avs.h sound/soc/intel/avs/pcm.c+350 -00 replies
6/15ASoC: Intel: avs: Coredump and recovery flowsound/soc/intel/Kconfig sound/soc/intel/avs/avs.h sound/soc/intel/avs/ipc.c +1 more+105 -20 replies
7/15ASoC: Intel: avs: Prepare for firmware tracingsound/soc/intel/avs/avs.h sound/soc/intel/avs/ipc.c sound/soc/intel/avs/messages.c +3 more+113 -00 replies
8/15ASoC: Intel: avs: D0ix power state supportsound/soc/intel/avs/avs.h sound/soc/intel/avs/dsp.c sound/soc/intel/avs/ipc.c +1 more+150 -30 replies
9/15ASoC: Intel: avs: Event tracingsound/soc/intel/avs/Makefile sound/soc/intel/avs/dsp.c sound/soc/intel/avs/ipc.c +2 more+228 -30 replies
10/15ASoC: Intel: avs: Replace link_mask usage with i2s_link_masksound/soc/intel/avs/topology.c+6 -60 replies
11/15ASoC: Intel: avs: Machine board registrationsound/soc/intel/avs/Makefile sound/soc/intel/avs/avs.h sound/soc/intel/avs/board_selection.c+505 -115 replies
12/15ASoC: Intel: avs: PCI driver implementationinclude/sound/intel-dsp-config.h sound/soc/intel/Kconfig sound/soc/intel/avs/avs.h +3 more+499 -40 replies
13/15ASoC: Intel: avs: Power managementsound/soc/intel/avs/core.c+101 -00 replies
14/15ASoC: Intel: avs: SKL-based platforms supportsound/soc/intel/avs/Makefile sound/soc/intel/avs/avs.h sound/soc/intel/avs/core.c +3 more+170 -00 replies
15/15ASoC: Intel: avs: APL-based platforms supportsound/soc/intel/avs/Makefile sound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h +4 more+295 -10 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchGuenter RoeckCezary Rojewski
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15R-b R-b R-b
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/15] ASoC: Intel: avs: Driver core and PCM operations

Part three of main AVS driver series. This series was originally part of the initial series which was later divided [1] into smaller, easier-to-review chunks. Thus, many patches found here were already present on the list.

This series consists of code typical to many drivers - PCI driver operations, trace ability, PM operations - as well as PCM handlers for all standard audio interfaces, that is, HDA, I2S and DMIC are found here.

Series starts with updating firmware boot flow - libraries are no longer ignored. This change is dependent on already merged topology code [2] and because of that could not be part of the initial series [1].

PCM operations are split into four changes. First component operations alone i.e. operations which are usually agnostic towards path position (FE/BE). Then it continues with "generic" FE operations - there is no interface split here as from Intel ADSP point of view, FE, or HOST side as it's called in the specs, involves HD-Audio operations only. BE (also known as LINK) side on the other hand is divided into "non-HD-Audio" and HD-Audio part. The former represents transfer over DMIC and I2S interfaces both.

While patches implementing standard PCI driver operations along (again standard) HD-Audio initialization routines followed up by power management handlers are two major ones, series covers also other important subjects such as:

While patches implementing standard PCI driver operations along (again standard) HD-Audio initialization routines followed up by power management handlers are two major ones, series covers also other important subjects such as:

- event tracing
- preparation for firmware tracing (debugability)
- coredump (debugability)
- recovery flow (attempt recovery after IPC timeout or exception)
- D0ix (D0 device substate, complements standard power management)

Series is finalized by actual addition of supported platforms: SKL and APL-based. Platform-specific files are limited to firmware-specific bits, that is, bits that are specific to given firmware generation. Everything else is shared and is part of already upstream messaging code found in ipc.c, messages.c and messages.h files.

Changes in v3:
- addressed (hopefully) trace-code compilation under .configs with CONFIG_FTRACE dropped

Changes in v2:
- usage of avs_releast_last_firmware() dropped in error path for library loading procedure as suggested by Pierre
- 'link_mask' usage replaced with 'i2s_link_mask' as requested by Pierre. Existing code addressed with new patch:
"ASoC: Intel: avs: Replace link_mask usage with i2s_link_mask"
- fixed possible race during recovery flow (->recovering flag is now atomic and tested in single location only).
- dropped platform prefixes for basically all i2s board descriptors
- 'ssp_test' renamed to 'i2s_test' to match naming convention of other boards
- simplified PM implementation for current series, 'low_power' bits moved to future series
- replaced SND_INTEL_DSP_DRIVER_SST with _AVS as suggested by Mark. Required changes to intel-dspcfg will be added in future series
- number of typos across commit messages addressed

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/

Cezary Rojewski (14):
ASoC: Intel: avs: Account for libraries when booting basefw
ASoC: Intel: avs: Generic soc component driver
ASoC: Intel: avs: Generic PCM FE operations
ASoC: Intel: avs: non-HDA PCM BE operations
ASoC: Intel: avs: HDA PCM BE operations
ASoC: Intel: avs: Coredump and recovery flow
ASoC: Intel: avs: Prepare for firmware tracing
ASoC: Intel: avs: D0ix power state support
ASoC: Intel: avs: Event tracing
ASoC: Intel: avs: Machine board registration
ASoC: Intel: avs: PCI driver implementation
ASoC: Intel: avs: Power management
ASoC: Intel: avs: SKL-based platforms support
ASoC: Intel: avs: APL-based platforms support

Piotr Maziarz (1):
ASoC: Intel: avs: Replace link_mask usage with i2s_link_mask

 include/sound/intel-dsp-config.h      |    3 +-
 include/sound/soc-acpi.h              |    2 +
 sound/soc/intel/Kconfig               |    2 +
 sound/soc/intel/avs/Makefile          |    7 +-
 sound/soc/intel/avs/apl.c             |  250 ++++++
 sound/soc/intel/avs/avs.h             |   79 ++
 sound/soc/intel/avs/board_selection.c |  501 +++++++++++
 sound/soc/intel/avs/core.c            |  631 +++++++++++++
 sound/soc/intel/avs/dsp.c             |   27 +-
 sound/soc/intel/avs/ipc.c             |  253 +++++-
 sound/soc/intel/avs/loader.c          |   84 ++
 sound/soc/intel/avs/messages.c        |   35 +-
 sound/soc/intel/avs/messages.h        |   51 ++
 sound/soc/intel/avs/pcm.c             | 1182 +++++++++++++++++++++++++
 sound/soc/intel/avs/registers.h       |    8 +
 sound/soc/intel/avs/skl.c             |  125 +++
 sound/soc/intel/avs/topology.c        |   14 +-
 sound/soc/intel/avs/trace.c           |   33 +
 sound/soc/intel/avs/trace.h           |  154 ++++
 sound/soc/intel/avs/utils.c           |   23 +
 20 files changed, 3443 insertions(+), 21 deletions(-)
 create mode 100644 sound/soc/intel/avs/apl.c
 create mode 100644 sound/soc/intel/avs/board_selection.c
 create mode 100644 sound/soc/intel/avs/pcm.c
 create mode 100644 sound/soc/intel/avs/skl.c
 create mode 100644 sound/soc/intel/avs/trace.c
 create mode 100644 sound/soc/intel/avs/trace.h
Signature · 1 line
2.25.1