Skip to content

ASoC: Intel: avs: Machine boards and HDA codec support

Cezary Rojewski alsa-devel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 5 repliesIn review
  2. v114 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- 'link_mask' usage replaced with 'i2s_link_mask' as requested by Pierre
- 'ssp_test' board renamed to 'i2s_test' to match naming convention used for other i2s machine boards
- enriched commit message and Kconfig for the 'HD-Audio codec driver' patch as requested by Kai

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14ALSA: Add snd_pcm_direction_name() helperinclude/sound/pcm.h+15 -40 replies
2/14ASoC: codecs: Add HD-Audio codec driversound/soc/codecs/Kconfig sound/soc/codecs/Makefile sound/soc/codecs/hda-dai.c +2 more+528 -02 replies
3/14ASoC: Intel: avs: Add HDAudio machine boardsound/soc/intel/Kconfig sound/soc/intel/avs/Makefile sound/soc/intel/avs/boards/Kconfig +2 more+320 -00 replies
4/14ASoC: Intel: avs: Add DMIC machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/dmic.c+103 -00 replies
5/14ASoC: Intel: avs: Add I2S-test machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/i2s_test.c+188 -00 replies
6/14ASoC: Intel: avs: Add rt274 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/rt274.c+322 -00 replies
7/14ASoC: Intel: avs: Add rt286 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/rt286.c+293 -00 replies
8/14ASoC: Intel: avs: Add rt298 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/rt298.c+293 -00 replies
9/14ASoC: Intel: avs: Add rt5682 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/rt5682.c+352 -00 replies
10/14ASoC: Intel: avs: Add nau8825 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/nau8825.c+366 -00 replies
11/14ASoC: Intel: avs: Add ssm4567 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/ssm4567.c+284 -00 replies
12/14ASoC: Intel: avs: Add max98357a machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/max98357a.c+166 -00 replies
13/14ASoC: Intel: avs: Add max98373 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/max98373.c+251 -00 replies
14/14ASoC: Intel: avs: Add da7219 machine boardsound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile sound/soc/intel/avs/boards/da7219.c+294 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/14] ASoC: Intel: avs: Machine boards and HDA codec support

This series focuses on populating boards/ subdirectory with supported configurations by the avs-driver. Note: it is independent of recently provided "Driver code and PCM operations" series [1], that is, code found here should not collide with it.

Series starts with a small change that adds a helper to sound pcm header, allowing for retrieving string naming a direction without the need of substream pointer. Said helper is used by codec driver code that follows it but I believe it's generic and helpful enough that it can be called an independent addition to the sound core.

Code for generic HD-Audio codec driver follows. It is a ASoC wrapper for existing HD-Audio codec code found in sound/pci/hda/. There is basically no custom logic involved up to the point that driver follows HDA_DEV_LEGACY convention, rather than the HDA_DEV_ASOC one. Commit message for the given patch iterates on this and explains crucial parts of the implementation.

From there on is a range of boards appended. All of them follow the same scheme:

- define avs_create_dai_link() so DAI-LINKs can be created dynamically, based on the link_mask (I2S) or the number of entries in the ->pcm_list_head list (HDA)
- define avs_create_dapm_routes() so DAPM routes can be created dynamically, same rules as above apply
- define probe() function that creates new ASoC card, assign all required operations and resources along with calling the two above

Changes in v2:
- 'link_mask' usage replaced with 'i2s_link_mask' as requested by Pierre
- 'ssp_test' board renamed to 'i2s_test' to match naming convention used for other i2s machine boards
- enriched commit message and Kconfig for the 'HD-Audio codec driver' patch as requested by Kai

[1]: https://lore.kernel.org/all/[email protected]/

Amadeusz Sławiński (1):
ASoC: Intel: avs: Add max98373 machine board

Cezary Rojewski (13):
ALSA: Add snd_pcm_direction_name() helper
ASoC: codecs: Add HD-Audio codec driver
ASoC: Intel: avs: Add HDAudio machine board
ASoC: Intel: avs: Add DMIC machine board
ASoC: Intel: avs: Add I2S-test machine board
ASoC: Intel: avs: Add rt274 machine board
ASoC: Intel: avs: Add rt286 machine board
ASoC: Intel: avs: Add rt298 machine board
ASoC: Intel: avs: Add rt5682 machine board
ASoC: Intel: avs: Add nau8825 machine board
ASoC: Intel: avs: Add ssm4567 machine board
ASoC: Intel: avs: Add max98357a machine board
ASoC: Intel: avs: Add da7219 machine board

 include/sound/pcm.h                    |  19 +-
 sound/soc/codecs/Kconfig               |  10 +
 sound/soc/codecs/Makefile              |   2 +
 sound/soc/codecs/hda-dai.c             | 102 +++++++
 sound/soc/codecs/hda.c                 | 395 +++++++++++++++++++++++++
 sound/soc/codecs/hda.h                 |  19 ++
 sound/soc/intel/Kconfig                |   3 +
 sound/soc/intel/avs/Makefile           |   3 +
 sound/soc/intel/avs/boards/Kconfig     | 121 ++++++++
 sound/soc/intel/avs/boards/Makefile    |  27 ++
 sound/soc/intel/avs/boards/da7219.c    | 282 ++++++++++++++++++
 sound/soc/intel/avs/boards/dmic.c      |  93 ++++++
 sound/soc/intel/avs/boards/hdaudio.c   | 294 ++++++++++++++++++
 sound/soc/intel/avs/boards/i2s_test.c  | 180 +++++++++++
 sound/soc/intel/avs/boards/max98357a.c | 154 ++++++++++
 sound/soc/intel/avs/boards/max98373.c  | 239 +++++++++++++++
 sound/soc/intel/avs/boards/nau8825.c   | 353 ++++++++++++++++++++++
 sound/soc/intel/avs/boards/rt274.c     | 310 +++++++++++++++++++
 sound/soc/intel/avs/boards/rt286.c     | 281 ++++++++++++++++++
 sound/soc/intel/avs/boards/rt298.c     | 281 ++++++++++++++++++
 sound/soc/intel/avs/boards/rt5682.c    | 340 +++++++++++++++++++++
 sound/soc/intel/avs/boards/ssm4567.c   | 271 +++++++++++++++++
 22 files changed, 3775 insertions(+), 4 deletions(-)
 create mode 100644 sound/soc/codecs/hda-dai.c
 create mode 100644 sound/soc/codecs/hda.c
 create mode 100644 sound/soc/codecs/hda.h
 create mode 100644 sound/soc/intel/avs/boards/Kconfig
 create mode 100644 sound/soc/intel/avs/boards/Makefile
 create mode 100644 sound/soc/intel/avs/boards/da7219.c
 create mode 100644 sound/soc/intel/avs/boards/dmic.c
 create mode 100644 sound/soc/intel/avs/boards/hdaudio.c
 create mode 100644 sound/soc/intel/avs/boards/i2s_test.c
 create mode 100644 sound/soc/intel/avs/boards/max98357a.c
 create mode 100644 sound/soc/intel/avs/boards/max98373.c
 create mode 100644 sound/soc/intel/avs/boards/nau8825.c
 create mode 100644 sound/soc/intel/avs/boards/rt274.c
 create mode 100644 sound/soc/intel/avs/boards/rt286.c
 create mode 100644 sound/soc/intel/avs/boards/rt298.c
 create mode 100644 sound/soc/intel/avs/boards/rt5682.c
 create mode 100644 sound/soc/intel/avs/boards/ssm4567.c
Signature · 1 line
2.25.1