Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | block: Classify bdrv_get_flags() as I/O functionblock.c include/ include/ | +2 | 1 reply | |
| 2/4 | qcow2: Do not reopen data_file in invalidate_cacheblock/ | +62 | 2 replies | |
| 3/4 | Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"include/ | +1 | 1 reply | |
| 4/4 | iotests: Add regression test for issue 945tests/ tests/ | +86 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
Hi,
This assertion was disabled in commit b1c073490553f80594b903ceedfc7c1aef6b1b19. We wanted to re-enable it once the 7.1 tree has opened (which is now), but to do so, we should also fix the bug reported in
https://gitlab.com/qemu-project/qemu/-/issues/945 .
Patches 1 and 2 fix that problem (I hope), patch 3 re-enables the assertion, and patch 4 adds a regression test for issue 945.
Hanna Reitz (4):
block: Classify bdrv_get_flags() as I/O function
qcow2: Do not reopen data_file in invalidate_cache Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions"
iotests: Add regression test for issue 945
include/block/block-global-state.h | 1 - include/block/block-io.h | 1 + include/qemu/main-loop.h | 3 +- block.c | 2 +- block/qcow2.c | 104 +++++++++++------- .../tests/export-incoming-iothread | 81 ++++++++++++++ .../tests/export-incoming-iothread.out | 5 + 7 files changed, 151 insertions(+), 46 deletions(-) create mode 100755 tests/qemu-iotests/tests/export-incoming-iothread create mode 100644 tests/qemu-iotests/tests/export-incoming-iothread.out
Signature · 1 line
2.35.1