Skip to content

platform: allow ATOM PMC code to be optional

Paul Gortmaker linux-acpi lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4platform/x86: pmc_atom: remove unused pmc_atom_write()drivers/platform/x86/pmc_atom.c include/linux/platform_data/x86/pmc_atom.h+0 -132 replies
2/4ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicitarch/x86/Kconfig+1 -02 replies
3/4platform/x86: pmc_atom: dont export pmc_atom_read - no modular usersdrivers/platform/x86/pmc_atom.c+0 -11 reply
4/4platform/x86: pmc_atom: make the PMC driver actually unselectabledrivers/platform/x86/Kconfig+8 -32 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchRafael J. Wysocki
1/4
2/4A-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] platform: allow ATOM PMC code to be optional

A few months back I was doing a test build for "defconfig-like" COTS hardware and happened to notice some pmc-atom stuff being built. Fine, I thought - the defconfig isn't minimal - we all know that - what Kconfig do I use to turn that off? Well, imagine my surprise when I found out you couldn't turn it [Atom Power Management Controller] code off!

Normally we all agree to not use "default y" unless unavoidable, but somehow this was added as "def_bool y" which is even worse ; you can see the Kconfig setting but there is *no* way you can turn it off.

After investigating, I found no reason why the atom code couldn't be opt-out with just minor changes that the original addition overlooked.

And so this series addreses that. I tried to be sensitive to not break any existing configs in the process, but the defconfig will now intentionally be different and exclude this atom specific code.

Using a defconfig on today's linux-next, here is the delta summary:

$ ./scripts/bloat-o-meter -c ../pmc-atom-pre/vmlinux ../pmc-atom-post/vmlinux|grep add/remove
add/remove: 0/410 grow/shrink: 0/7 up/down: 0/-47659 (-47659)
add/remove: 0/105 grow/shrink: 0/1 up/down: 0/-6848 (-6848)
add/remove: 0/56 grow/shrink: 0/1 up/down: 0/-10155 (-10155)
$ ./scripts/bloat-o-meter -c ../pmc-atom-pre/vmlinux ../pmc-atom-post/vmlinux|grep Total
Total: Before=13626994, After=13579335, chg -0.35%
Total: Before=3572137, After=3565289, chg -0.19%
Total: Before=1235335, After=1225180, chg -0.82%

It is hard to reclaim anything against the inevitable growth in footprint, so I'd say we should be glad to take whatever we can.

Boot tested defconfig on today's linux-next on older non-atom COTS.

Paul.

Cc Andy Shevchenko <[email protected]>
Cc Aubrey Li <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Len Brown <[email protected]>
Cc Mark Gross <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

---

Paul Gortmaker (4):
platform/x86: pmc_atom: remove unused pmc_atom_write()
ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicit platform/x86: pmc_atom: dont export pmc_atom_read - no modular users platform/x86: pmc_atom: make the PMC driver actually unselectable

 arch/x86/Kconfig                           |  1 +
 drivers/platform/x86/Kconfig               | 11 ++++++++---
 drivers/platform/x86/pmc_atom.c            | 13 -------------
 include/linux/platform_data/x86/pmc_atom.h |  1 -
 4 files changed, 9 insertions(+), 17 deletions(-)
Signature · 1 line
2.17.1