s390x/tcg: Implement Vector-Enhancements Facility 2
Get series with b4
b4 am [email protected]Versions newest first
- v6 Latest13 patches 12 repliesIn review
Changes in v6 from the cover letter
* Move fix to #1
* Include max CPU model cleanups
* "target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model" -> Take care of compat machines
* "tests/tcg/s390x: Tests for Vector Enhancements Facility 2" -> Add missing newline to end of header file
-> Resolve simple conflict in Makefile
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | target/s390x: Fix writeback to v1 in helper_vstltarget/ | +0 | 0 replies | |
| 2/13 | s390x/cpu_models: drop "msa5" from the TCG "max" modeltarget/ | +0 | 0 replies | |
| 3/13 | s390x/cpu_models: make "max" match the unmodified "qemu" CPU model under TCGtarget/ target/ | +13 | 0 replies | |
| 4/13 | tcg: Implement tcg_gen_{h,w}swap_{i32,i64}include/ tcg/ | +36 | 0 replies | |
| 5/13 | target/s390x: vxeh2: vector convert short/32btarget/ target/ target/ | +75 | 0 replies | |
| 6/13 | target/s390x: vxeh2: vector string searchtarget/ target/ target/ +2 more | +134 | 0 replies | |
| 7/13 | target/s390x: vxeh2: Update for changes to vector shiftstarget/ target/ target/ +1 more | +95 | 0 replies | |
| 8/13 | target/s390x: vxeh2: vector shift double by bittarget/ target/ | +53 | 0 replies | |
| 9/13 | target/s390x: vxeh2: vector {load, store} elements reversedtarget/ target/ | +88 | 0 replies | |
| 10/13 | target/s390x: vxeh2: vector {load, store} byte reversed elementstarget/ target/ | +117 | 0 replies | |
| 11/13 | target/s390x: vxeh2: vector {load, store} byte reversed elementtarget/ target/ | +97 | 0 replies | |
| 12/13 | target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU modelhw/ target/ | +9 | 0 replies | |
| 13/13 | tests/tcg/s390x: Tests for Vector Enhancements Facility 2tests/ tests/ tests/ +2 more | +347 | 3 replies |
Reviews trailers per patch
10 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Thomas Huth | Cornelia Huck | Richard Henderson | David Miller | David Hildenbrand |
|---|---|---|---|---|---|
| 1/13 | T-b | R-b | R-b | ||
| 2/13 | R-b | R-b | R-b | ||
| 3/13 | R-b | R-b | |||
| 4/13 | R-b | R-b | |||
| 5/13 | T-b | R-b | |||
| 6/13 | T-b | R-b | |||
| 7/13 | T-b | R-b | |||
| 8/13 | T-b | ||||
| 9/13 | T-b | R-b | |||
| 10/13 | T-b | R-b | |||
| 11/13 | T-b | R-b | |||
| 12/13 | |||||
| 13/13 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v6 00/13] s390x/tcg: Implement Vector-Enhancements Facility 2
Implement Vector-Enhancements Facility 2 for s390x
resolves: https://gitlab.com/qemu-project/qemu/-/issues/738
implements:
VECTOR LOAD ELEMENTS REVERSED (VLER)
VECTOR LOAD BYTE REVERSED ELEMENTS (VLBR)
VECTOR LOAD BYTE REVERSED ELEMENT (VLEBRH, VLEBRF, VLEBRG)
VECTOR LOAD BYTE REVERSED ELEMENT AND ZERO (VLLEBRZ) VECTOR LOAD BYTE REVERSED ELEMENT AND REPLICATE (VLBRREP)
VECTOR STORE ELEMENTS REVERSED (VSTER)
VECTOR STORE BYTE REVERSED ELEMENTS (VSTBR)
VECTOR STORE BYTE REVERSED ELEMENTS (VSTEBRH, VSTEBRF, VSTEBRG)
VECTOR SHIFT LEFT DOUBLE BY BIT (VSLD)
VECTOR SHIFT RIGHT DOUBLE BY BIT (VSRD)
VECTOR STRING SEARCH (VSTRS)
modifies:
VECTOR FP CONVERT FROM FIXED (VCFPS)
VECTOR FP CONVERT FROM LOGICAL (VCFPL)
VECTOR FP CONVERT TO FIXED (VCSFP)
VECTOR FP CONVERT TO LOGICAL (VCLFP)
VECTOR SHIFT LEFT (VSL)
VECTOR SHIFT RIGHT ARITHMETIC (VSRA)
VECTOR SHIFT RIGHT LOGICAL (VSRL)
v5 -> v6:
* Move fix to #1
* Include max CPU model cleanups
* "target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model" -> Take care of compat machines
* "tests/tcg/s390x: Tests for Vector Enhancements Facility 2" -> Add missing newline to end of header file
-> Resolve simple conflict in Makefile
David Hildenbrand (2):
s390x/cpu_models: drop "msa5" from the TCG "max" model s390x/cpu_models: make "max" match the unmodified "qemu" CPU model
under TCG
David Miller (9):
target/s390x: vxeh2: vector convert short/32b target/s390x: vxeh2: vector string search target/s390x: vxeh2: Update for changes to vector shifts target/s390x: vxeh2: vector shift double by bit target/s390x: vxeh2: vector {load, store} elements reversed target/s390x: vxeh2: vector {load, store} byte reversed elements target/s390x: vxeh2: vector {load, store} byte reversed element target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model tests/tcg/s390x: Tests for Vector Enhancements Facility 2
Richard Henderson (2):
target/s390x: Fix writeback to v1 in helper_vstl
tcg: Implement tcg_gen_{h,w}swap_{i32,i64}
hw/s390x/s390-virtio-ccw.c | 3 + include/tcg/tcg-op.h | 6 + target/s390x/cpu_models.c | 26 +- target/s390x/gen-features.c | 14 +- target/s390x/helper.h | 13 + target/s390x/tcg/insn-data.def | 40 ++- target/s390x/tcg/translate.c | 3 +- target/s390x/tcg/translate_vx.c.inc | 461 ++++++++++++++++++++++++--- target/s390x/tcg/vec_fpu_helper.c | 31 ++ target/s390x/tcg/vec_helper.c | 2 - target/s390x/tcg/vec_int_helper.c | 55 ++++ target/s390x/tcg/vec_string_helper.c | 99 ++++++ tcg/tcg-op.c | 30 ++ tests/tcg/s390x/Makefile.target | 8 + tests/tcg/s390x/vx.h | 19 ++ tests/tcg/s390x/vxeh2_vcvt.c | 88 +++++ tests/tcg/s390x/vxeh2_vlstr.c | 139 ++++++++ tests/tcg/s390x/vxeh2_vs.c | 93 ++++++ 18 files changed, 1051 insertions(+), 79 deletions(-) create mode 100644 tests/tcg/s390x/vx.h create mode 100644 tests/tcg/s390x/vxeh2_vcvt.c create mode 100644 tests/tcg/s390x/vxeh2_vlstr.c create mode 100644 tests/tcg/s390x/vxeh2_vs.c
Signature · 1 line
2.35.1