Skip to content

s390x/tcg: Implement Vector-Enhancements Facility 2

David Hildenbrand qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v6 Latest13 patches 12 repliesIn review

Changes in v6 from the cover letter

* Move fix to #1
* Include max CPU model cleanups
* "target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model" -> Take care of compat machines
* "tests/tcg/s390x: Tests for Vector Enhancements Facility 2" -> Add missing newline to end of header file
-> Resolve simple conflict in Makefile

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13target/s390x: Fix writeback to v1 in helper_vstltarget/s390x/tcg/vec_helper.c+0 -20 replies
2/13s390x/cpu_models: drop "msa5" from the TCG "max" modeltarget/s390x/gen-features.c+0 -20 replies
3/13s390x/cpu_models: make "max" match the unmodified "qemu" CPU model under TCGtarget/s390x/cpu_models.c target/s390x/gen-features.c+13 -240 replies
4/13tcg: Implement tcg_gen_{h,w}swap_{i32,i64}include/tcg/tcg-op.h tcg/tcg-op.c+36 -00 replies
5/13target/s390x: vxeh2: vector convert short/32btarget/s390x/helper.h target/s390x/tcg/translate_vx.c.inc target/s390x/tcg/vec_fpu_helper.c+75 -40 replies
6/13target/s390x: vxeh2: vector string searchtarget/s390x/helper.h target/s390x/tcg/insn-data.def target/s390x/tcg/translate.c +2 more+134 -10 replies
7/13target/s390x: vxeh2: Update for changes to vector shiftstarget/s390x/helper.h target/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc +1 more+95 -500 replies
8/13target/s390x: vxeh2: vector shift double by bittarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+53 -80 replies
9/13target/s390x: vxeh2: vector {load, store} elements reversedtarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+88 -00 replies
10/13target/s390x: vxeh2: vector {load, store} byte reversed elementstarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+117 -00 replies
11/13target/s390x: vxeh2: vector {load, store} byte reversed elementtarget/s390x/tcg/insn-data.def target/s390x/tcg/translate_vx.c.inc+97 -00 replies
12/13target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU modelhw/s390x/s390-virtio-ccw.c target/s390x/gen-features.c+9 -10 replies
13/13tests/tcg/s390x: Tests for Vector Enhancements Facility 2tests/tcg/s390x/Makefile.target tests/tcg/s390x/vx.h tests/tcg/s390x/vxeh2_vcvt.c +2 more+347 -03 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchThomas HuthCornelia HuckRichard HendersonDavid MillerDavid Hildenbrand
1/13T-b R-b R-b
2/13R-b R-b R-b
3/13R-b R-b
4/13R-b R-b
5/13T-b R-b
6/13T-b R-b
7/13T-b R-b
8/13T-b
9/13T-b R-b
10/13T-b R-b
11/13T-b R-b
12/13
13/13T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/13] s390x/tcg: Implement Vector-Enhancements Facility 2

Implement Vector-Enhancements Facility 2 for s390x

resolves: https://gitlab.com/qemu-project/qemu/-/issues/738

implements:

    VECTOR LOAD ELEMENTS REVERSED               (VLER)
    VECTOR LOAD BYTE REVERSED ELEMENTS          (VLBR)
    VECTOR LOAD BYTE REVERSED ELEMENT           (VLEBRH, VLEBRF, VLEBRG)
    VECTOR LOAD BYTE REVERSED ELEMENT AND ZERO  (VLLEBRZ)

VECTOR LOAD BYTE REVERSED ELEMENT AND REPLICATE (VLBRREP)
VECTOR STORE ELEMENTS REVERSED (VSTER)
VECTOR STORE BYTE REVERSED ELEMENTS (VSTBR)
VECTOR STORE BYTE REVERSED ELEMENTS (VSTEBRH, VSTEBRF, VSTEBRG)
VECTOR SHIFT LEFT DOUBLE BY BIT (VSLD)
VECTOR SHIFT RIGHT DOUBLE BY BIT (VSRD)
VECTOR STRING SEARCH (VSTRS)

modifies:
VECTOR FP CONVERT FROM FIXED (VCFPS)
VECTOR FP CONVERT FROM LOGICAL (VCFPL)
VECTOR FP CONVERT TO FIXED (VCSFP)
VECTOR FP CONVERT TO LOGICAL (VCLFP)
VECTOR SHIFT LEFT (VSL)
VECTOR SHIFT RIGHT ARITHMETIC (VSRA)
VECTOR SHIFT RIGHT LOGICAL (VSRL)

v5 -> v6:
* Move fix to #1
* Include max CPU model cleanups
* "target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model" -> Take care of compat machines
* "tests/tcg/s390x: Tests for Vector Enhancements Facility 2" -> Add missing newline to end of header file
-> Resolve simple conflict in Makefile

Cc Thomas Huth <[email protected]>
Cc Richard Henderson <[email protected]>
Cc David Miller <[email protected]>
Cc Christian Borntraeger <[email protected]>
Cc Cornelia Huck <[email protected]>
Cc Halil Pasic <[email protected]>
Cc Eric Farman <[email protected]>

David Hildenbrand (2):
s390x/cpu_models: drop "msa5" from the TCG "max" model s390x/cpu_models: make "max" match the unmodified "qemu" CPU model
under TCG

David Miller (9):
target/s390x: vxeh2: vector convert short/32b target/s390x: vxeh2: vector string search target/s390x: vxeh2: Update for changes to vector shifts target/s390x: vxeh2: vector shift double by bit target/s390x: vxeh2: vector {load, store} elements reversed target/s390x: vxeh2: vector {load, store} byte reversed elements target/s390x: vxeh2: vector {load, store} byte reversed element target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Richard Henderson (2):
target/s390x: Fix writeback to v1 in helper_vstl
tcg: Implement tcg_gen_{h,w}swap_{i32,i64}

 hw/s390x/s390-virtio-ccw.c           |   3 +
 include/tcg/tcg-op.h                 |   6 +
 target/s390x/cpu_models.c            |  26 +-
 target/s390x/gen-features.c          |  14 +-
 target/s390x/helper.h                |  13 +
 target/s390x/tcg/insn-data.def       |  40 ++-
 target/s390x/tcg/translate.c         |   3 +-
 target/s390x/tcg/translate_vx.c.inc  | 461 ++++++++++++++++++++++++---
 target/s390x/tcg/vec_fpu_helper.c    |  31 ++
 target/s390x/tcg/vec_helper.c        |   2 -
 target/s390x/tcg/vec_int_helper.c    |  55 ++++
 target/s390x/tcg/vec_string_helper.c |  99 ++++++
 tcg/tcg-op.c                         |  30 ++
 tests/tcg/s390x/Makefile.target      |   8 +
 tests/tcg/s390x/vx.h                 |  19 ++
 tests/tcg/s390x/vxeh2_vcvt.c         |  88 +++++
 tests/tcg/s390x/vxeh2_vlstr.c        | 139 ++++++++
 tests/tcg/s390x/vxeh2_vs.c           |  93 ++++++
 18 files changed, 1051 insertions(+), 79 deletions(-)
 create mode 100644 tests/tcg/s390x/vx.h
 create mode 100644 tests/tcg/s390x/vxeh2_vcvt.c
 create mode 100644 tests/tcg/s390x/vxeh2_vlstr.c
 create mode 100644 tests/tcg/s390x/vxeh2_vs.c
Signature · 1 line
2.35.1