Skip to content

ext4: Fix crash when adding entry to corrupted directory

Jan Kara linux-ext4 stable 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyApplied
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* Fixed compilation error in the first patch (which got fixed in the second patch)
* Fixed stack corruption issue with largedir feature

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2ext4: Verify dir block before splitting itfs/ext4/namei.c+21 -111 reply
2/2ext4: Avoid cycles in directory h-treefs/ext4/namei.c+19 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/2 v2] ext4: Fix crash when adding entry to corrupted directory

Hello,

two patches in this series try to fix a crash when adding directory entry to a directory with corrupted h-tree. Since I don't have the filesystem image causing the crash, I'm not sure what was the cause but the stacktrace suggests we have corrupted one h-tree node while modifying another one so likely there was a cycle created in the h-tree. This series checks for it and bails out early.

Changes since v1:
* Fixed compilation error in the first patch (which got fixed in the second patch)
* Fixed stack corruption issue with largedir feature

Honza

Previous versions: