Skip to content

Fix bpf mem read/write vulnerability.

Hao Luo stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10bpf: Introduce composable reg, ret and arg types.include/linux/bpf.h include/linux/bpf_verifier.h+56 -00 replies
2/10bpf: Replace ARG_XXX_OR_NULL with ARG_XXX | PTR_MAYBE_NULLinclude/linux/bpf.h kernel/bpf/verifier.c+23 -310 replies
3/10bpf: Replace RET_XXX_OR_NULL with RET_XXX | PTR_MAYBE_NULLinclude/linux/bpf.h kernel/bpf/helpers.c kernel/bpf/verifier.c+39 -340 replies
4/10bpf: Replace PTR_TO_XXX_OR_NULL with PTR_TO_XXX | PTR_MAYBE_NULLinclude/linux/bpf.h include/linux/bpf_verifier.h kernel/bpf/btf.c +4 more+148 -1860 replies
5/10bpf: Introduce MEM_RDONLY flaginclude/linux/bpf.h kernel/bpf/btf.c kernel/bpf/map_iter.c +3 more+60 -430 replies
6/10bpf: Convert PTR_TO_MEM_OR_NULL to composable types.include/linux/bpf.h kernel/bpf/btf.c kernel/bpf/verifier.c+2 -30 replies
7/10bpf: Make per_cpu_ptr return rdonly PTR_TO_MEM.kernel/bpf/helpers.c kernel/bpf/verifier.c+28 -60 replies
8/10bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem.include/linux/bpf.h kernel/bpf/btf.c kernel/bpf/cgroup.c +6 more+71 -550 replies
9/10bpf/selftests: Test PTR_TO_RDONLY_MEMtools/testing/selftests/bpf/prog_tests/ksyms_btf.c tools/testing/selftests/bpf/progs/test_ksyms_btf_write_check.c+43 -00 replies
10/10bpf: Fix crash due to out of bounds access into reg2btf_ids.kernel/bpf/btf.c+2 -20 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchAndrii Nakryiko
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10A-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH stable linux-5.15.y 00/10] Fix bpf mem read/write vulnerability.

Hi Greg,

Please cherry-pick this patch series into 5.15.y stable. It includes a feature that fixes CVE-2022-0500 which allows a user with cap_bpf privileges to get root privileges. The patch that fixes the bug is

patch 7/10: bpf: Make per_cpu_ptr return rdonly

The rest are the depedences required by the fix patch. Note that v5.10 and below are not affected by this bug.

This patchset has been merged in mainline v5.17 and backported to v5.16[1], except patch 10/10 ("bpf: Fix crash due to out of bounds access into reg2btf_ids."), which fixes an out-of-bound access in the main feature in this series and hasn't been backported to v5.16 yet. If it's convenient, could you apply patch 10/10 to 5.16? I can send a separate patch for v5.16, if you prefer.

Tested by compile, build and run through the bpf selftest test_progs.

[1] https://www.spinics.net/lists/stable/msg535877.html

Hao Luo (9):
bpf: Introduce composable reg, ret and arg types.
bpf: Replace ARG_XXX_OR_NULL with ARG_XXX | PTR_MAYBE_NULL
bpf: Replace RET_XXX_OR_NULL with RET_XXX | PTR_MAYBE_NULL
bpf: Replace PTR_TO_XXX_OR_NULL with PTR_TO_XXX | PTR_MAYBE_NULL
bpf: Introduce MEM_RDONLY flag
bpf: Convert PTR_TO_MEM_OR_NULL to composable types.
bpf: Make per_cpu_ptr return rdonly PTR_TO_MEM.
bpf: Add MEM_RDONLY for helper args that are pointers to rdonly mem. bpf/selftests: Test PTR_TO_RDONLY_MEM

Kumar Kartikeya Dwivedi (1):
bpf: Fix crash due to out of bounds access into reg2btf_ids.

 include/linux/bpf.h                           | 101 +++-
 include/linux/bpf_verifier.h                  |  18 +
 kernel/bpf/btf.c                              |  16 +-
 kernel/bpf/cgroup.c                           |   2 +-
 kernel/bpf/helpers.c                          |  12 +-
 kernel/bpf/map_iter.c                         |   4 +-
 kernel/bpf/ringbuf.c                          |   2 +-
 kernel/bpf/syscall.c                          |   2 +-
 kernel/bpf/verifier.c                         | 488 +++++++++---------
 kernel/trace/bpf_trace.c                      |  22 +-
 net/core/bpf_sk_storage.c                     |   2 +-
 net/core/filter.c                             |  64 +--
 net/core/sock_map.c                           |   2 +-
 .../selftests/bpf/prog_tests/ksyms_btf.c      |  14 +
 .../bpf/progs/test_ksyms_btf_write_check.c    |  29 ++
 15 files changed, 445 insertions(+), 333 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/test_ksyms_btf_write_check.c
Signature · 1 line
2.36.0.464.gb9c8b46e94-goog