mlxsw: Remove size limitations on egress descriptor buffer
Status from this message: This series was applied to netdev/net-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | mlxsw: reg: Add "desc" field to SBPRdrivers/ | +6 | 0 replies | Applied |
| 2/4 | mlxsw: Configure descriptor buffersdrivers/ | +26 | 0 replies | Applied |
| 3/4 | selftests: forwarding: lib: Add start_traffic_pktsize() helperstools/ | +18 | 0 replies | Applied |
| 4/4 | selftests: mlxsw: Add a test for soaking up a burst of traffictools/ | +480 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 0/4] mlxsw: Remove size limitations on egress descriptor buffer
Petr says:
Spectrum machines have two resources related to keeping packets in an internal buffer: bytes (allocated in cell-sized units) for packet payload, and descriptors, for keeping headers. Currently, mlxsw only configures the bytes part of the resource management.
Spectrum switches permit a full parallel configuration for the descriptor resources, including port-pool and port-TC-pool quotas. By default, these are all configured to use pool 14, with an infinite quota. The ingress pool 14 is then infinite in size.
However, egress pool 14 has finite size by default. The size is chip dependent, but always much lower than what the chip actually permits. As a result, we can easily construct workloads that exhaust the configured descriptor limit.
Going forward, mlxsw will have to fix this issue properly by maintaining descriptor buffer sizes, TC bindings, and quotas that match the architecture recommendation. Short term, fix the issue by configuring the egress descriptor pool to be infinite in size as well. This will maintain the same configuration philosophy, but will unlock all chip resources to be usable.
In this patchset, patch #1 first adds the "desc" field into the pool configuration register. Then in patch #2, the new field is used to configure both ingress and egress pool 14 as infinite.
In patches #3 and #4, add a selftest that verifies that a large burst can be absorbed by the shared buffer. This test specifically exercises a scenario where descriptor buffer is the limiting factor and the test fails without the above patches.
Petr Machata (4):
mlxsw: reg: Add "desc" field to SBPR
mlxsw: Configure descriptor buffers
selftests: forwarding: lib: Add start_traffic_pktsize() helpers
selftests: mlxsw: Add a test for soaking up a burst of traffic
drivers/net/ethernet/mellanox/mlxsw/reg.h | 6 + .../mellanox/mlxsw/spectrum_buffers.c | 26 + .../selftests/drivers/net/mlxsw/qos_burst.sh | 480 ++++++++++++++++++ tools/testing/selftests/net/forwarding/lib.sh | 21 +- 4 files changed, 530 insertions(+), 3 deletions(-) create mode 100755 tools/testing/selftests/drivers/net/mlxsw/qos_burst.sh
Signature · 1 line
2.35.1