staging: vchiq_arm: remove some unnecessary global variables
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 5 repliesIn review
- v13 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- added more info in commit messages
- split commit removing the 'vchiq_states' array into several changes to make the review easier.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | staging: vchiq_arm: add reference to vchiq device in vchiq_statedrivers/ drivers/ drivers/ | +6 | 0 replies | |
| 2/9 | staging: vchiq_arm: get rid of global device structuredrivers/ drivers/ drivers/ +4 more | +53 | 0 replies | |
| 3/9 | staging: vchiq_arm: pass vchiq instance to service callbacksdrivers/ drivers/ drivers/ +3 more | +18 | 1 reply | |
| 4/9 | staging: vchiq_arm: pass vchiq instance to 'find_service_by_handle'drivers/ drivers/ drivers/ +5 more | +118 | 1 reply | |
| 5/9 | staging: vchiq_arm: pass vchiq instance to 'vchiq_get_client_id'drivers/ drivers/ drivers/ | +3 | 0 replies | |
| 6/9 | staging: vchiq_arm: pass vchiq instance to 'vchiq_get_service_userdata'drivers/ drivers/ drivers/ +1 more | +5 | 0 replies | |
| 7/9 | staging: vchiq_arm: pass vchiq instance to 'handle_to_service'drivers/ drivers/ drivers/ | +7 | 0 replies | |
| 8/9 | staging: vchiq_arm: use state from vchiq instancedrivers/ drivers/ | +8 | 1 reply | |
| 9/9 | staging: vchiq_arm: remove global 'vchiq_states' arraydrivers/ drivers/ | +0 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by.
| Patch | Stefan Wahren |
|---|---|
| Series | T-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/9] staging: vchiq_arm: remove some unnecessary global variables
This patch series aims at removing some unnecessary global structures (namely, 'g_dev' and 'vchiq_states'), in order to make the driver more robust. This is part of an effort to address TODO item "Get rid of all non essential global structures and create a proper per device structure".
Changes since v1:
- added more info in commit messages
- split commit removing the 'vchiq_states' array into several changes to make the review easier.
Adrien Thierry (9):
staging: vchiq_arm: add reference to vchiq device in vchiq_state
staging: vchiq_arm: get rid of global device structure
staging: vchiq_arm: pass vchiq instance to service callbacks
staging: vchiq_arm: pass vchiq instance to 'find_service_by_handle'
staging: vchiq_arm: pass vchiq instance to 'vchiq_get_client_id'
staging: vchiq_arm: pass vchiq instance to
'vchiq_get_service_userdata'
staging: vchiq_arm: pass vchiq instance to 'handle_to_service'
staging: vchiq_arm: use state from vchiq instance
staging: vchiq_arm: remove global 'vchiq_states' array
.../bcm2835-audio/bcm2835-vchiq.c | 40 +++++--- .../include/linux/raspberrypi/vchiq.h | 48 +++++---- .../interface/vchiq_arm/vchiq_arm.c | 92 ++++++++---------- .../interface/vchiq_arm/vchiq_arm.h | 8 +- .../interface/vchiq_arm/vchiq_core.c | 97 ++++++++++--------- .../interface/vchiq_arm/vchiq_core.h | 38 +++----- .../interface/vchiq_arm/vchiq_dev.c | 40 ++++---- .../vc04_services/vchiq-mmal/mmal-vchiq.c | 63 ++++++------ 8 files changed, 217 insertions(+), 209 deletions(-)
base-commit: e41f7a5521d7f03dca99e3207633df71740569dd
Signature · 1 line
2.35.3