Skip to content

scsi: EH rework prep patches, part 1

Hannes Reinecke linux-scsi llvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 46 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24csiostor: use fc_block_rport()drivers/scsi/csiostor/csio_scsi.c+1 -13 replies
2/24fc_fcp: use fc_block_rport()drivers/scsi/libfc/fc_fcp.c+1 -13 replies
3/24zfcp: open-code fc_block_scsi_eh() for host resetdrivers/s390/scsi/zfcp_scsi.c+23 -63 replies
4/24mptfc: simplify mpt_fc_block_error_handler()drivers/message/fusion/mptfc.c+54 -291 reply
5/24mptfusion: correct definitions for mptscsih_dev_reset()drivers/message/fusion/mptscsih.c drivers/message/fusion/mptscsih.h+55 -11 reply
6/24mptfc: open-code mptfc_block_error_handler() for bus resetdrivers/message/fusion/mptfc.c+14 -31 reply
7/24qedf: use fc rport as argument for qedf_initiate_tmf()drivers/scsi/qedf/qedf.h drivers/scsi/qedf/qedf_io.c drivers/scsi/qedf/qedf_main.c+33 -661 reply
8/24bnx2fc: Do not rely on a scsi command for lun or target resetdrivers/scsi/bnx2fc/bnx2fc.h drivers/scsi/bnx2fc/bnx2fc_hwi.c drivers/scsi/bnx2fc/bnx2fc_io.c+57 -521 reply
9/24ibmvfc: open-code reset loop for target resetdrivers/scsi/ibmvscsi/ibmvfc.c+23 -191 reply
10/24ibmvfc: use fc_block_rport()drivers/scsi/ibmvscsi/ibmvfc.c+4 -23 replies
11/24fnic: use dedicated device reset commanddrivers/scsi/fnic/fnic_scsi.c+36 -951 reply
12/24fnic: use fc_block_rport() correctlydrivers/scsi/fnic/fnic_scsi.c+4 -32 replies
13/24aic7xxx: make BUILD_SCSIID() a functiondrivers/scsi/aic7xxx/aic7xxx_osm.c+11 -62 replies
14/24aic79xx: make BUILD_SCSIID() a functiondrivers/scsi/aic7xxx/aic79xx_osm.c+10 -42 replies
15/24aic7xxx: do not reference scsi command when resetting devicedrivers/scsi/aic7xxx/aic7xxx_osm.c+54 -481 reply
16/24aic79xx: do not reference scsi command when resetting devicedrivers/scsi/aic7xxx/aic79xx_osm.c+15 -62 replies
17/24snic: reserve tag for TMFdrivers/scsi/snic/snic.h drivers/scsi/snic/snic_main.c drivers/scsi/snic/snic_scsi.c+26 -238 replies
18/24snic: use dedicated device reset commanddrivers/scsi/snic/snic_scsi.c+24 -281 reply
19/24snic: Use scsi_host_busy_iter() to traverse commandsdrivers/scsi/snic/snic_scsi.c+84 -931 reply
20/24sym53c8xx_2: split off bus reset from host resetdrivers/scsi/sym53c8xx_2/sym_glue.c+66 -412 replies
21/24ips: Do not try to abort command from host resetdrivers/scsi/ips.c+0 -182 replies
22/24qla1280: separate out host reset function from qla1280_error_action()drivers/scsi/qla1280.c+21 -191 reply
23/24megaraid: pass in NULL scb for host resetdrivers/scsi/megaraid.c+16 -262 replies
24/24mpi3mr: split off bus_reset function from host_resetdrivers/scsi/mpi3mr/mpi3mr_os.c+37 -201 reply

Reviews trailers per patch

22 of 24 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigJohannes ThumshirnBart Van Assche
1/24R-b R-b R-b
2/24R-b R-b R-b
3/24R-b
4/24R-b
5/24R-b
6/24R-b
7/24R-b
8/24R-b
9/24R-b
10/24R-b R-b R-b
11/24R-b
12/24R-b R-b
13/24
14/24
15/24R-b
16/24R-b R-b
17/24R-b R-b
18/24R-b
19/24R-b
20/24R-b R-b
21/24R-b R-b
22/24R-b
23/24R-b R-b
24/24R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/24] scsi: EH rework prep patches, part 1

Hi all,

here's the first batch of patches for my EH rework. It modifies the host reset callback for SCSI drivers such that the final conversion to have 'struct Scsi_host' as argument becomes possible.

As usual, comments and reviews are welcome.

Hannes Reinecke (24):
csiostor: use fc_block_rport()
fc_fcp: use fc_block_rport()
zfcp: open-code fc_block_scsi_eh() for host reset
mptfc: simplify mpt_fc_block_error_handler()
mptfusion: correct definitions for mptscsih_dev_reset()
mptfc: open-code mptfc_block_error_handler() for bus reset
qedf: use fc rport as argument for qedf_initiate_tmf()
bnx2fc: Do not rely on a scsi command for lun or target reset
ibmvfc: open-code reset loop for target reset
ibmvfc: use fc_block_rport()
fnic: use dedicated device reset command
fnic: use fc_block_rport() correctly
aic7xxx: make BUILD_SCSIID() a function
aic79xx: make BUILD_SCSIID() a function
aic7xxx: do not reference scsi command when resetting device
aic79xx: do not reference scsi command when resetting device
snic: reserve tag for TMF
snic: use dedicated device reset command
snic: Use scsi_host_busy_iter() to traverse commands
sym53c8xx_2: split off bus reset from host reset
ips: Do not try to abort command from host reset
qla1280: separate out host reset function from qla1280_error_action()
megaraid: pass in NULL scb for host reset
mpi3mr: split off bus_reset function from host_reset

 drivers/message/fusion/mptfc.c      |  94 +++++++---
 drivers/message/fusion/mptscsih.c   |  55 +++++-
 drivers/message/fusion/mptscsih.h   |   1 +
 drivers/s390/scsi/zfcp_scsi.c       |  29 ++-
 drivers/scsi/aic7xxx/aic79xx_osm.c  |  35 ++--
 drivers/scsi/aic7xxx/aic7xxx_osm.c  | 119 ++++++------
 drivers/scsi/bnx2fc/bnx2fc.h        |   1 +
 drivers/scsi/bnx2fc/bnx2fc_hwi.c    |  14 +-
 drivers/scsi/bnx2fc/bnx2fc_io.c     |  94 +++++-----
 drivers/scsi/csiostor/csio_scsi.c   |   2 +-
 drivers/scsi/fnic/fnic_scsi.c       | 138 +++++---------
 drivers/scsi/ibmvscsi/ibmvfc.c      |  48 ++---
 drivers/scsi/ips.c                  |  18 --
 drivers/scsi/libfc/fc_fcp.c         |   2 +-
 drivers/scsi/megaraid.c             |  42 ++---
 drivers/scsi/mpi3mr/mpi3mr_os.c     |  57 +++---
 drivers/scsi/qedf/qedf.h            |   5 +-
 drivers/scsi/qedf/qedf_io.c         |  75 +++-----
 drivers/scsi/qedf/qedf_main.c       |  19 +-
 drivers/scsi/qla1280.c              |  40 +++--
 drivers/scsi/snic/snic.h            |   3 +-
 drivers/scsi/snic/snic_main.c       |   3 +
 drivers/scsi/snic/snic_scsi.c       | 270 +++++++++++++---------------
 drivers/scsi/sym53c8xx_2/sym_glue.c | 107 ++++++-----
 24 files changed, 665 insertions(+), 606 deletions(-)
Signature · 1 line
2.29.2