hw/arm/aspeed: Add fby35 machine type
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | hw/arm/aspeed: Add fby35 machine typehw/ tests/ | +82 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] hw/arm/aspeed: Add fby35 machine type
Hey everyone,
I'm submitting another Facebook (Meta Platforms) machine type: this time I'm including an acceptance test too.
Unfortunately, this machine boots _very_ slowly. 300+ seconds. I'm not sure why this is (so I don't know how to fix it easily) and I don't know how to override the avocado test timeout just for a single test, so I increased the global timeout for all "boot_linux_console.py" tests from 90s to 400s. I doubt this is acceptable, but what other option is there? Should I add AVOCADO_TIMEOUT_EXPECTED?
@skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
What is the point of this environment variable though, except to skip it in CIT? If I run the test with this environment variable defined, it doesn't disable the timeout, it just skips it right? I want an option to run this test with a larger timeout.
Thanks,
Peter
Peter Delevoryas (1):
hw/arm/aspeed: Add fby35 machine type
hw/arm/aspeed.c | 63 +++++++++++++++++++++++++++++ tests/avocado/boot_linux_console.py | 20 ++++++++- 2 files changed, 82 insertions(+), 1 deletion(-)
Signature · 1 line
2.30.2