multipath-tools: fix unit test breakage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | multipath-tools: enable local configdir and plugindir for unit testslibmultipath/ tests/ tests/ | +27 | 0 replies | |
| 2/7 | tests/mpathvalid: fix check for DEFAULT_CONFIG_FILEtests/ | +1 | 0 replies | |
| 3/7 | multipath-tools tests: hwtable: adapt after removal of getuidtests/ tests/ tests/ | +140 | 0 replies | |
| 4/7 | tests/hwtable: fix test_regex_2_strings_hwe_dirtests/ tests/ | +2 | 0 replies | |
| 5/7 | libmultipath: fix valgrind_testlibmultipath/ | +3 | 0 replies | |
| 6/7 | tests/Makefile: make TESTDIR configurabletests/ | +5 | 0 replies | |
| 7/7 | github workflows: foreign.yaml: fix config dir in run environment.github/ | +5 | 0 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Benjamin Marzinski |
|---|---|
| Series | R-b |
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [dm-devel] [PATCH 0/7] multipath-tools: fix unit test breakage
From: Martin Wilck <[email protected]>
Hi Christophe, hi Ben,
The previous patches
af15832 multipath-tools: make multipath_dir a compiled-in option 1fc7c4d multipath-tools: make config_dir a compiled-in option 21b3d6b multipath-tools: stop supporting getuid_callout
have caused breakage in the unit tests. Not so much because they'd actually break the tests, but because they broke the compilation and the search paths for the configuration files (for the former two commits) and because the hwtable test relied on being able to the retrieve the now removed "getuid_callout" property from config files.
Fix it. As always, comments welcome.
Regards
Martin
Martin Wilck (7):
multipath-tools: enable local configdir and plugindir for unit tests tests/mpathvalid: fix check for DEFAULT_CONFIG_FILE multipath-tools tests: hwtable: adapt after removal of getuid tests/hwtable: fix test_regex_2_strings_hwe_dir
libmultipath: fix valgrind_test
tests/Makefile: make TESTDIR configurable
github workflows: foreign.yaml: fix config dir in run environment
.github/workflows/foreign.yaml | 7 +- libmultipath/Makefile | 24 ++++-- libmultipath/config.c | 3 + tests/Makefile | 12 ++- tests/hwtable.c | 151 ++++++++++++++++----------------- tests/mpathvalid.c | 2 +- tests/test-lib.c | 89 ++++++++++++++----- tests/test-lib.h | 2 +- 8 files changed, 180 insertions(+), 110 deletions(-)
Signature · 6 lines
2.36.0 -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel