Skip to content

PCIe Aardvark controller backports for 5.15

Marek Behún stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest30 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30PCI: pci-bridge-emul: Add description for class_revision fielddrivers/pci/pci-bridge-emul.c+5 -10 replies
2/30PCI: pci-bridge-emul: Add definitions for missing capabilities registersdrivers/pci/pci-bridge-emul.c+43 -00 replies
3/30PCI: aardvark: Add support for DEVCAP2, DEVCTL2, LNKCAP2 and LNKCTL2 registers on emulated bridgedrivers/pci/controller/pci-aardvark.c+11 -40 replies
4/30PCI: aardvark: Clear all MSIs at setupdrivers/pci/controller/pci-aardvark.c+4 -20 replies
5/30PCI: aardvark: Comment actions in driver remove methoddrivers/pci/controller/pci-aardvark.c+2 -00 replies
6/30PCI: aardvark: Disable bus mastering when unbinding driverdrivers/pci/controller/pci-aardvark.c+6 -00 replies
7/30PCI: aardvark: Mask all interrupts when unbinding driverdrivers/pci/controller/pci-aardvark.c+21 -00 replies
8/30PCI: aardvark: Fix memory leak in driver unbinddrivers/pci/controller/pci-aardvark.c+3 -00 replies
9/30PCI: aardvark: Assert PERST# when unbinding driverdrivers/pci/controller/pci-aardvark.c+4 -00 replies
10/30PCI: aardvark: Disable link training when unbinding driverdrivers/pci/controller/pci-aardvark.c+5 -00 replies
11/30PCI: aardvark: Disable common PHY when unbinding driverdrivers/pci/controller/pci-aardvark.c+3 -00 replies
12/30PCI: aardvark: Replace custom PCIE_CORE_INT_* macros with PCI_INTERRUPT_*drivers/pci/controller/pci-aardvark.c+1 -50 replies
13/30PCI: aardvark: Rewrite IRQ code to chained IRQ handlerdrivers/pci/controller/pci-aardvark.c+26 -220 replies
14/30PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQdrivers/pci/controller/pci-aardvark.c+3 -10 replies
15/30PCI: aardvark: Make MSI irq_chip structures static driver structuresdrivers/pci/controller/pci-aardvark.c+12 -140 replies
16/30PCI: aardvark: Make msi_domain_info structure a static driver structuredrivers/pci/controller/pci-aardvark.c+8 -80 replies
17/30PCI: aardvark: Use dev_fwnode() instead of of_node_to_fwnode(dev->of_node)drivers/pci/controller/pci-aardvark.c+1 -20 replies
18/30PCI: aardvark: Refactor unmasking summary MSI interruptdrivers/pci/controller/pci-aardvark.c+6 -40 replies
19/30PCI: aardvark: Add support for masking MSI interruptsdrivers/pci/controller/pci-aardvark.c+49 -50 replies
20/30PCI: aardvark: Fix setting MSI addressdrivers/pci/controller/pci-aardvark.c+9 -120 replies
21/30PCI: aardvark: Enable MSI-X supportdrivers/pci/controller/pci-aardvark.c+1 -10 replies
22/30PCI: aardvark: Add support for ERR interrupt on emulated bridgedrivers/pci/controller/pci-aardvark.c+34 -10 replies
23/30PCI: aardvark: Optimize writing PCI_EXP_RTCTL_PMEIE and PCI_EXP_RTSTA_PME on emulated bridgedrivers/pci/controller/pci-aardvark.c+11 -90 replies
24/30PCI: aardvark: Add support for PME interruptsdrivers/pci/controller/pci-aardvark.c+12 -00 replies
25/30PCI: aardvark: Fix support for PME requester on emulated bridgedrivers/pci/controller/pci-aardvark.c+50 -410 replies
26/30PCI: aardvark: Use separate INTA interrupt for emulated root bridgedrivers/pci/controller/pci-aardvark.c+67 -20 replies
27/30PCI: aardvark: Remove irq_mask_ack() callback for INTx interruptsdrivers/pci/controller/pci-aardvark.c+0 -10 replies
28/30PCI: aardvark: Don't mask irq when mappingdrivers/pci/controller/pci-aardvark.c+0 -10 replies
29/30PCI: aardvark: Drop __maybe_unused from advk_pcie_disable_phy()drivers/pci/controller/pci-aardvark.c+1 -10 replies
30/30PCI: aardvark: Update comment about link going down after link-updrivers/pci/controller/pci-aardvark.c+6 -20 replies

Reviews trailers per patch

3 of 30 patches have a Reviewed-by or Acked-by.

PatchMarc ZyngierBjorn Helgaas
1/30
2/30
3/30
4/30
5/30
6/30
7/30
8/30
9/30
10/30
11/30
12/30R-b
13/30
14/30
15/30
16/30
17/30
18/30
19/30
20/30A-b
21/30
22/30
23/30
24/30
25/30
26/30
27/30A-b
28/30
29/30
30/30

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 5.15 00/30] PCIe Aardvark controller backports for 5.15

Hello Greg, Sasha,

this is backport of all the recet changes for the Aardvark PCIe controller for 5.15.
These include
- memory leak fix in driver unbind
- more complete driver unbind
- fixes for MSI support
- add MSI-X support, which fixes support for some cards
- add ERR interrupt support (which we really missed when debugging)

I also included some small cosmetic changes - this will make it easier to backport next fixes for the driver (there is another batch pending on linux-pci).

Marek

Marek Behún (5):
PCI: aardvark: Make MSI irq_chip structures static driver structures
PCI: aardvark: Make msi_domain_info structure a static driver
structure
PCI: aardvark: Use dev_fwnode() instead of

    of_node_to_fwnode(dev->of_node)

PCI: aardvark: Drop __maybe_unused from advk_pcie_disable_phy()
PCI: aardvark: Update comment about link going down after link-up

Pali Rohár (25):
PCI: pci-bridge-emul: Add description for class_revision field
PCI: pci-bridge-emul: Add definitions for missing capabilities
registers
PCI: aardvark: Add support for DEVCAP2, DEVCTL2, LNKCAP2 and LNKCTL2
registers on emulated bridge
PCI: aardvark: Clear all MSIs at setup
PCI: aardvark: Comment actions in driver remove method
PCI: aardvark: Disable bus mastering when unbinding driver
PCI: aardvark: Mask all interrupts when unbinding driver
PCI: aardvark: Fix memory leak in driver unbind
PCI: aardvark: Assert PERST# when unbinding driver
PCI: aardvark: Disable link training when unbinding driver
PCI: aardvark: Disable common PHY when unbinding driver
PCI: aardvark: Replace custom PCIE_CORE_INT_* macros with
PCI_INTERRUPT_*
PCI: aardvark: Rewrite IRQ code to chained IRQ handler
PCI: aardvark: Check return value of generic_handle_domain_irq() when
processing INTx IRQ
PCI: aardvark: Refactor unmasking summary MSI interrupt
PCI: aardvark: Add support for masking MSI interrupts
PCI: aardvark: Fix setting MSI address
PCI: aardvark: Enable MSI-X support
PCI: aardvark: Add support for ERR interrupt on emulated bridge
PCI: aardvark: Optimize writing PCI_EXP_RTCTL_PMEIE and
PCI_EXP_RTSTA_PME on emulated bridge
PCI: aardvark: Add support for PME interrupts
PCI: aardvark: Fix support for PME requester on emulated bridge
PCI: aardvark: Use separate INTA interrupt for emulated root bridge
PCI: aardvark: Remove irq_mask_ack() callback for INTx interrupts
PCI: aardvark: Don't mask irq when mapping

 drivers/pci/controller/pci-aardvark.c | 428 +++++++++++++++++++-------
 drivers/pci/pci-bridge-emul.c         |  49 ++-
 2 files changed, 371 insertions(+), 106 deletions(-)
Signature · 1 line
2.35.1