Skip to content

PM/Thermal: Enhance PCH overheat handling

Zhang Rui linux-pm 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyIn review
  2. v17 patches 22 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4PM: wakeup: expose pm_wakeup_pending to modulesdrivers/base/power/wakeup.c+1 -00 replies
2/4thermal: intel: pch: move cooling delay to suspend_noirq phasedrivers/thermal/intel/intel_pch_thermal.c+3 -20 replies
3/4thermal: intel: pch: enhance overheat handlingdrivers/thermal/intel/intel_pch_thermal.c+8 -50 replies
4/4thermal: intel: pch: improve the cooling delay logdrivers/thermal/intel/intel_pch_thermal.c+20 -110 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchSumeet Pawnikar
1/4T-b
2/4T-b
3/4T-b
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/4] PM/Thermal: Enhance PCH overheat handling

On some Intel client platforms like SKL/KBL/CNL/CML, there is a PCH thermal sensor that monitors the PCH temperature and blocks the system from entering S0ix in case it overheats.

Commit ef63b043ac86 ("thermal: intel: pch: fix S0ix failure due to PCH temperature above threshold") introduces a delay loop to cool the temperature down for this purpose.

However, in practice, we found that the time it takes to cool the PCH down below threshold highly depends on the initial PCH temperature when the delay starts, as well as the ambient temperature.

For example, on a Dell XPS 9360 laptop, the problem can be triggered
1. when it is suspended with heavy workload running.
or
2. when it is moved from New Hampshire to Florida.

In these cases, the 1 second delay is not sufficient. As a result, the system stays in a shallower power state like PCx instead of S0ix, and drains the battery power, without user' notice.

In order to fix this, we
1. move the delay to .suspend_noirq phase instead, in order to do the cooling when the system is in a more quiescent state
2. expand the default overall cooling delay timeout to 60 seconds.
3. make sure the temperature is below threshold rather than equal to it.

Compared with V1, the last four patches are dropped from the series, and we focus on the PCH Overheat issue only. Plus, splitted one of the patch according to Rafael' suggestion.

thanks,
rui