Skip to content

Fix topdown event weak grouping

Ian Rogers linux-perf-users lkml 3 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 14 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2perf evlist: Keep topdown counters in weak grouptools/perf/arch/x86/util/evsel.c tools/perf/util/evlist.c tools/perf/util/evsel.c +1 more+39 -20 replies
2/2perf test: Add basic stat and topdown group testtools/perf/tests/shell/stat.sh+67 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKan Liang
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Fix topdown event weak grouping

Keep topdown events within a group when a weak group is broken. This is a requirement as topdown events must form a group.

Add perf stat testing including for required topdown event group behaviors.

Note: as with existing topdown evsel/evlist code topdown events are assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should also be tested. Future changes can fix Alderlake.

v3. Fix computation of number of events in leader's group.
Adds reviewed-by: Liang, Kan <[email protected]
v2. Correct behavior wrt pmu prefixed events and avoid the test using
deprecated events: Suggested-by: Liang, Kan <[email protected]>

Ian Rogers (2):
perf evlist: Keep topdown counters in weak group perf test: Add basic stat and topdown group test

 tools/perf/arch/x86/util/evsel.c | 12 ++++++
 tools/perf/tests/shell/stat.sh   | 67 ++++++++++++++++++++++++++++++++
 tools/perf/util/evlist.c         | 16 +++++++-
 tools/perf/util/evsel.c          | 10 +++++
 tools/perf/util/evsel.h          |  3 ++
 5 files changed, 106 insertions(+), 2 deletions(-)
 create mode 100755 tools/perf/tests/shell/stat.sh
Signature · 1 line
2.36.0.550.gb090851708-goog