Skip to content

firmware: mtk: add adsp ipc protocol for SOF

Tinghan Shen alsa-devel linux-arm-kernel linux-mediatek lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest3 patches 1 replyIn review
  2. v83 patches 0 repliesSuperseded
  3. v71 patch 4 repliesSuperseded

Changes in v9 from the cover letter

- fix patchset 2 and 3.
move "depends on MTK_ADSP_IPC" from SND_SOC_SOF_MTK_COMMON to SND_SOC_SOF_MT8195/MT8186 to prevent generating wrong config.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3firmware: mediatek: Add adsp ipc protocol interfacedrivers/firmware/Kconfig drivers/firmware/Makefile drivers/firmware/mtk-adsp-ipc.c +1 more+232 -00 replies
2/3ASoC: SOF: mediatek: Add ipc support for mt8195sound/soc/sof/mediatek/Kconfig sound/soc/sof/mediatek/adsp_helper.h sound/soc/sof/mediatek/mt8195/mt8195.c+140 -110 replies
3/3ASoC: SOF: mediatek: Add mt8186 ipc supportsound/soc/sof/mediatek/Kconfig sound/soc/sof/mediatek/mt8186/mt8186-loader.c sound/soc/sof/mediatek/mt8186/mt8186.c+147 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchPierre-Louis BossartCurtis MalaineyTzung-Bi ShihYC HungAngeloGioacchino Del Regno
1/3R-b R-b R-b R-b R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v9 thread

Cover letter [PATCH v9 0/3] firmware: mtk: add adsp ipc protocol for SOF

This patch provides mediatek adsp ipc support for SOF. ADSP IPC protocol offers (send/recv) interfaces using mediatek-mailbox APIs.

This patch was tested and confirmed to work with SOF fw on MT8195 cherry board and MT8186 krabby board.

changes since v8:
- fix patchset 2 and 3.
move "depends on MTK_ADSP_IPC" from SND_SOC_SOF_MTK_COMMON to SND_SOC_SOF_MT8195/MT8186 to prevent generating wrong config.

changes since v7:
- rebase to linux-next/next-22020504
- use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL in mtk-adsp-ipc.c
- move mtk-adsp-ipc.c out from driver/firmware/mediatek
- add user of mtk-adsp-ipc.h in patchset 2 and 3.

changes since v6:
- rebase to matthias.bgg/linux.git, v5.18-next/soc
- Prefer "GPL" over "GPL v2" for MODULE_LICENSE

changes since v5:
- fix WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox /mtk-adsp-mailbox.o. Add MODULE_LICENSE in the last line.
- Due to WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 in checkpatch, we don't remove SPDX-License in line 1.

changes since v4:
- add error message for wrong mbox chan

changes since v3:
- rebase on v5.16-rc8
- update reviewers

changes since v2:
- add out tag for two memory free phases

changes since v1:
- add comments for mtk_adsp_ipc_send and mtk_adsp_ipc_recv
- remove useless MODULE_LICENSE
- change label name to out_free

Allen-KH Cheng (1):
ASoC: SOF: mediatek: Add ipc support for mt8195

TingHan Shen (1):
firmware: mediatek: add adsp ipc protocol interface

Tinghan Shen (1):
ASoC: SOF: mediatek: Add mt8186 ipc support

 drivers/firmware/Kconfig                      |   9 +
 drivers/firmware/Makefile                     |   1 +
 drivers/firmware/mtk-adsp-ipc.c               | 157 ++++++++++++++++++
 .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 ++++++++
 sound/soc/sof/mediatek/Kconfig                |   2 +
 sound/soc/sof/mediatek/adsp_helper.h          |  12 +-
 sound/soc/sof/mediatek/mt8186/mt8186-loader.c |   5 +
 sound/soc/sof/mediatek/mt8186/mt8186.c        | 141 ++++++++++++++++
 sound/soc/sof/mediatek/mt8195/mt8195.c        | 138 ++++++++++++++-
 9 files changed, 519 insertions(+), 11 deletions(-)
 create mode 100644 drivers/firmware/mtk-adsp-ipc.c
 create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
Signature · 1 line
2.18.0