Skip to content

DC/DM changes needed for amdgpu PSR-SU

David Zhang amd-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 8 repliesIn review
  2. v117 patches 6 repliesSuperseded

Changes in v2 from the cover letter

-----------------------
- set vsc_packet_rev2 for PSR1 which is safer
- add exposure of AMD specific DPCD regs for PSR-SU-RC (rate-control)
- add DC/DM change related to amdgpu PSR-SU-RC

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19drm/amd/display: align dmub cmd header to latest dmub FW to support PSR-SUdrivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h+245 -50 replies
2/19drm/amd/display: feed PSR-SU as psr version to dmub FWdrivers/gpu/drm/amd/display/dc/dce/dmub_psr.c+3 -00 replies
3/19drm/amd/display: combine dirty rectangles in DMUB FWdrivers/gpu/drm/amd/display/dc/core/dc.c drivers/gpu/drm/amd/display/dc/dc_stream.h+59 -00 replies
4/19drm/amd/display: update GSP1 generic info packet for PSRSUdrivers/gpu/drm/amd/display/dc/dcn30/dcn30_dio_stream_encoder.c+15 -00 replies
5/19drm/amd/display: revise Start/End SDP datadrivers/gpu/drm/amd/display/modules/info_packet/info_packet.c+27 -20 replies
6/19drm/amd/display: program PSR2 DPCD Configurationdrivers/gpu/drm/amd/display/dc/core/dc_link.c drivers/gpu/drm/amd/display/dc/inc/hw/link_encoder.h+34 -20 replies
7/19drm/amd/display: Passing Y-granularity to dmub fwdrivers/gpu/drm/amd/display/dc/core/dc_link.c drivers/gpu/drm/amd/display/dc/dc_types.h drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c+18 -00 replies
8/19drm/amd/display: Set default value of line_capture_indicationdrivers/gpu/drm/amd/display/dc/dce/dmub_psr.c+1 -00 replies
9/19drm/amd/display: add vline time in micro sec to PSR contextdrivers/gpu/drm/amd/display/dc/core/dc_link.c drivers/gpu/drm/amd/display/dc/dc_types.h drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c+5 -00 replies
10/19drm/amd/display: fix system hang when PSR exitsdrivers/gpu/drm/amd/display/dc/dc_types.h drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c+23 -00 replies
11/19drm/amd/display: Set PSR level to enable ALPM by defaultdrivers/gpu/drm/amd/display/dc/core/dc_link.c drivers/gpu/drm/amd/display/dc/dc_types.h+7 -10 replies
12/19drm/amd/display: use HW lock mgr for PSR-SUdrivers/gpu/drm/amd/display/dc/dce/dmub_hw_lock_mgr.c+2 -00 replies
13/19drm/amd/display: PSRSU+DSC WA for specific TCONdrivers/gpu/drm/amd/display/dc/dc_link.h drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c+15 -00 replies
14/19drm/amd/display: add shared helpers to update psr config fields to power moduledrivers/gpu/drm/amd/display/modules/power/power_helpers.c drivers/gpu/drm/amd/display/modules/power/power_helpers.h+90 -00 replies
15/19drm/amd/display: calculate psr config settings in runtime in DMdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c+10 -50 replies
16/19drm/amd/display: update cursor position to DMUB FWdrivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c +1 more+136 -00 replies
17/19drm/amd/display: Implement MPO PSR SUdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c+144 -40 replies
18/19drm/amd/display: expose AMD source specific DPCD for FreeSync PSR supportdrivers/gpu/drm/amd/display/include/ddc_service_types.h+1 -00 replies
19/19drm/amd/display: PSR-SU rate control support in DCdrivers/gpu/drm/amd/display/dc/core/dc_link.c drivers/gpu/drm/amd/display/dc/dc_link.h drivers/gpu/drm/amd/display/dc/dc_types.h +3 more+52 -01 reply

Reviews trailers per patch

None of the 19 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHarry Wentland
SeriesR-b
1/19
2/19
3/19
4/19
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/19] DC/DM changes needed for amdgpu PSR-SU

changes in v2:
-----------------------
- set vsc_packet_rev2 for PSR1 which is safer
- add exposure of AMD specific DPCD regs for PSR-SU-RC (rate-control)
- add DC/DM change related to amdgpu PSR-SU-RC

David Zhang (18):
drm/amd/display: align dmub cmd header to latest dmub FW to support
PSR-SU
drm/amd/display: feed PSR-SU as psr version to dmub FW drm/amd/display: combine dirty rectangles in DMUB FW drm/amd/display: update GSP1 generic info packet for PSRSU drm/amd/display: revise Start/End SDP data drm/amd/display: program PSR2 DPCD Configuration drm/amd/display: Passing Y-granularity to dmub fw drm/amd/display: Set default value of line_capture_indication drm/amd/display: add vline time in micro sec to PSR context drm/amd/display: fix system hang when PSR exits drm/amd/display: Set PSR level to enable ALPM by default drm/amd/display: use HW lock mgr for PSR-SU drm/amd/display: PSRSU+DSC WA for specific TCON drm/amd/display: add shared helpers to update psr config fields to
power module
drm/amd/display: calculate psr config settings in runtime in DM drm/amd/display: update cursor position to DMUB FW drm/amd/display: expose AMD source specific DPCD for FreeSync PSR
support
drm/amd/display: PSR-SU rate control support in DC

Leo Li (1):
drm/amd/display: Implement MPO PSR SU

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 142 +++++++++-
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c |  21 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c      |  54 ++++
 drivers/gpu/drm/amd/display/dc/core/dc_link.c |  47 +++-
 drivers/gpu/drm/amd/display/dc/dc_link.h      |   4 +
 drivers/gpu/drm/amd/display/dc/dc_stream.h    |   5 +
 drivers/gpu/drm/amd/display/dc/dc_types.h     |  23 +-
 .../drm/amd/display/dc/dce/dmub_hw_lock_mgr.c |   2 +
 drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c |  64 +++++
 drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h |   2 +
 .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c |   2 +
 .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 131 +++++++++
 .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c |   2 +
 .../dc/dcn30/dcn30_dio_stream_encoder.c       |  15 ++
 drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h  |   1 +
 .../drm/amd/display/dc/inc/hw/link_encoder.h  |  21 +-
 .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h   | 250 +++++++++++++++++-
 .../amd/display/include/ddc_service_types.h   |   1 +
 .../display/modules/info_packet/info_packet.c |  29 +-
 .../amd/display/modules/power/power_helpers.c |  84 ++++++
 .../amd/display/modules/power/power_helpers.h |   6 +
 21 files changed, 887 insertions(+), 19 deletions(-)
Signature · 1 line
2.25.1