Skip to content

ast2600: Add I2C TPMv2 driver

Eddie James openbmc 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 3 repliesIn review
  2. v15 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Use upstream core for I2C tpm driver. I initially couldn't get the core driver to work at all, but found a small bug in the ordering of operations in the core init. I also needed to force the locality to 0, like in the Linux NPCT75X driver.
- Use new board init code for IBM's systems that need the TPM poisoning

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tpm: Add more TPM2 definitionsinclude/tpm-v2.h+31 -00 replies
2/9tpm: add #ifndef to fix redeclaration build errorsdrivers/tpm/tpm_tis.h+2 -00 replies
3/9tpm2: Introduce TIS tpm coredrivers/tpm/tpm2_tis_core.c drivers/tpm/tpm_tis.h include/tpm-v2.h+600 -00 replies
4/9tis: fix tpm_tis_remove()drivers/tpm/tpm2_tis_core.c+6 -00 replies
5/9tpm: core: Set timeouts before requesting localitydrivers/tpm/tpm2_tis_core.c+4 -30 replies
6/9i2c: ast_i2c: Remove SCL direct drive modedrivers/i2c/ast_i2c.c+1 -10 replies
7/9tpm: add support for TPMv2.x I2C chipsdrivers/tpm/Kconfig drivers/tpm/Makefile drivers/tpm/tpm2_tis_i2c.c+181 -00 replies
8/9arm: dts: ast2600-rainier: Add NPCT75X TPMarch/arm/dts/ast2600-rainier.dts+7 -50 replies
9/9board: ast2600-ibm: Add AST2600 BMC based POWER10+ serversarch/arm/mach-aspeed/ast2600/Kconfig board/aspeed/ast2600_ibm/Kconfig board/aspeed/ast2600_ibm/Makefile +2 more+204 -02 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchBin MengIlias Apalodimas
1/9R-b
2/9
3/9
4/9R-b
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH u-boot v2019.04-aspeed-openbmc v2 0/9] ast2600: Add I2C TPMv2 driver

This series backports the addition of a TPM TIS core driver from mainline u-boot. Then, add an I2C driver to talk to the NPCT75X chip using the TPM TIS core.
Add the TPM to the Rainier/Everest devicetree.
Also, add new board code for IBM's systems that need to "poison" the TPM during u-boot initialization.

I tested this on Everest hardware and verified in Linux that the TPM PCR0 was extended. I also tested with the TPM at the wrong bus address to verify that the code can handle a missing TPM, and I saw no errors.

Changes since v1:
- Use upstream core for I2C tpm driver. I initially couldn't get the core driver to work at all, but found a small bug in the ordering of operations in the core init. I also needed to force the locality to 0, like in the Linux NPCT75X driver.
- Use new board init code for IBM's systems that need the TPM poisoning

Eddie James (5):
tpm: core: Set timeouts before requesting locality
i2c: ast_i2c: Remove SCL direct drive mode
tpm: add support for TPMv2.x I2C chips
arm: dts: ast2600-rainier: Add NPCT75X TPM
board: ast2600-ibm: Add AST2600 BMC based POWER10+ servers

Heinrich Schuchardt (1):
tis: fix tpm_tis_remove()

Ilias Apalodimas (1):
tpm2: Introduce TIS tpm core

Johannes Holland (1):
tpm: add #ifndef to fix redeclaration build errors

Simon Glass (1):
tpm: Add more TPM2 definitions

 arch/arm/dts/ast2600-rainier.dts     |  12 +-
 arch/arm/mach-aspeed/ast2600/Kconfig |   7 +
 board/aspeed/ast2600_ibm/Kconfig     |  13 +
 board/aspeed/ast2600_ibm/Makefile    |   1 +
 board/aspeed/ast2600_ibm/ibm.c       |  46 +++
 configs/ast2600_ibm_defconfig        | 137 ++++++++
 drivers/i2c/ast_i2c.c                |   2 +-
 drivers/tpm/Kconfig                  |   9 +
 drivers/tpm/Makefile                 |   1 +
 drivers/tpm/tpm2_tis_core.c          | 470 +++++++++++++++++++++++++++
 drivers/tpm/tpm2_tis_i2c.c           | 171 ++++++++++
 drivers/tpm/tpm_tis.h                | 138 ++++++++
 include/tpm-v2.h                     |  32 ++
 13 files changed, 1033 insertions(+), 6 deletions(-)
 create mode 100644 board/aspeed/ast2600_ibm/Kconfig
 create mode 100644 board/aspeed/ast2600_ibm/Makefile
 create mode 100644 board/aspeed/ast2600_ibm/ibm.c
 create mode 100644 configs/ast2600_ibm_defconfig
 create mode 100644 drivers/tpm/tpm2_tis_core.c
 create mode 100644 drivers/tpm/tpm2_tis_i2c.c
Signature · 1 line
2.27.0