Skip to content

net: disambiguate the TSO and GSO limits

Jakub Kicinski netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4net: add netif_inherit_tso_max()drivers/net/ethernet/netronome/nfp/nfp_net_repr.c drivers/net/ipvlan/ipvlan_main.c drivers/net/macvlan.c +6 more+24 -181 replyApplied
2/4net: don't allow user space to lift the device limitsinclude/linux/netdevice.h net/core/dev.c net/core/rtnetlink.c+46 -20 repliesApplied
3/4net: make drivers set the TSO limit not the GSO limitdrivers/net/bonding/bond_main.c drivers/net/ethernet/atheros/atl1e/atl1e_main.c drivers/net/ethernet/cavium/liquidio/lio_main.c +25 more+49 -462 repliesApplied
4/4net: move netif_set_gso_max helpersinclude/linux/netdevice.h net/core/dev.h+21 -210 repliesApplied

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric DumazetSimon HormanMarcin Wojtas
SeriesR-b
1/4R-b
2/4
3/4R-b R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits

This series separates the device-reported TSO limitations from the user space-controlled GSO limits. It used to be that we only had the former (HW limits) but they were named GSO. This probably lead to confusion and letting user override them.

The problem came up in the BIG TCP discussion between Eric and Alex, and seems like something we should address.

Targeting net-next because (a) nobody is reporting problems; and (b) there is a tiny but non-zero chance that some actually wants to lift the HW limitations.

Jakub Kicinski (4):
net: add netif_inherit_tso_max()
net: don't allow user space to lift the device limits
net: make drivers set the TSO limit not the GSO limit
net: move netif_set_gso_max helpers

 drivers/net/bonding/bond_main.c               | 12 ++---
 .../net/ethernet/atheros/atl1e/atl1e_main.c   |  2 +-
 .../net/ethernet/cavium/liquidio/lio_main.c   |  2 +-
 .../ethernet/cavium/liquidio/lio_vf_main.c    |  2 +-
 drivers/net/ethernet/emulex/benet/be_main.c   |  2 +-
 drivers/net/ethernet/freescale/fec_main.c     |  2 +-
 drivers/net/ethernet/hisilicon/hns/hns_enet.c |  4 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  4 +-
 drivers/net/ethernet/marvell/mv643xx_eth.c    |  2 +-
 drivers/net/ethernet/marvell/mvneta.c         |  2 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   |  2 +-
 .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |  2 +-
 .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |  2 +-
 .../ethernet/netronome/nfp/nfp_net_common.c   |  2 +-
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |  5 +-
 drivers/net/ethernet/realtek/r8169_main.c     |  8 ++--
 drivers/net/ethernet/sfc/ef100_nic.c          |  9 ++--
 drivers/net/ethernet/sfc/efx.c                |  2 +-
 drivers/net/ethernet/sfc/falcon/efx.c         |  2 +-
 drivers/net/hyperv/rndis_filter.c             |  2 +-
 drivers/net/ipvlan/ipvlan_main.c              |  6 +--
 drivers/net/macvlan.c                         |  6 +--
 drivers/net/usb/aqc111.c                      |  2 +-
 drivers/net/usb/ax88179_178a.c                |  2 +-
 drivers/net/usb/lan78xx.c                     |  2 +-
 drivers/net/usb/r8152.c                       |  2 +-
 drivers/net/veth.c                            |  3 +-
 drivers/net/vxlan/vxlan_core.c                |  3 +-
 drivers/s390/net/qeth_l2_main.c               |  2 +-
 drivers/s390/net/qeth_l3_main.c               |  2 +-
 include/linux/netdevice.h                     | 31 +++++-------
 net/8021q/vlan.c                              |  3 +-
 net/8021q/vlan_dev.c                          |  3 +-
 net/bridge/br_if.c                            | 12 ++---
 net/core/dev.c                                | 47 +++++++++++++++++++
 net/core/dev.h                                | 21 +++++++++
 net/core/rtnetlink.c                          |  4 +-
 37 files changed, 137 insertions(+), 84 deletions(-)
Signature · 1 line
2.34.1