Skip to content

introduce per-queue available descriptor threshold and host shaper

Spike Du dpdk-dev 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest6 patches 2 repliesIn review
  2. v96 patches 0 repliesSuperseded
  3. v86 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v57 patches4 repliesSuperseded
v47 patches10 repliesSuperseded
v37 patches9 repliesSuperseded
v2 RFC7 patches18 repliesSuperseded
v1 RFC7 patches1 replySuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net/mlx5: add LWM support for Rxqdrivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_devx.c drivers/net/mlx5/mlx5_devx.h +1 more+15 -10 replies
2/6common/mlx5: share interrupt managementdrivers/common/mlx5/linux/mlx5_common_os.c drivers/common/mlx5/linux/mlx5_common_os.h drivers/common/mlx5/version.map +8 more+217 -3071 reply
3/6net/mlx5: add LWM event handling supportdrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_devx.c +2 more+160 -00 replies
4/6net/mlx5: support Rx queue based available descriptor thresholddoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_22_07.rst drivers/common/mlx5/mlx5_prm.h +3 more+172 -00 replies
5/6net/mlx5: add private API to config host port shaperdoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_22_07.rst drivers/common/mlx5/linux/meson.build +5 more+212 -00 replies
6/6app/testpmd: add Host Shaper commandapp/test-pmd/testpmd.c doc/guides/nics/mlx5.rst drivers/net/mlx5/meson.build +2 more+287 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMatan Azard
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 0/6] introduce per-queue available descriptor threshold and host shaper

available descriptor threshold(ADT for short) is per RX queue attribute, when RX queue available descriptors for HW is below ADT, HW sends an event to application. Host shaper can configure shaper rate and avail_thresh-triggered for a host port.
The shaper limits the rate of traffic from host port to embedded ARM rx port on Nvidia BlueField 2 NIC.
If avail_thresh-triggered is enabled, a 100Mbps shaper is enabled automatically when one of the host port's Rx queues receives available descriptor threshold event.

These two features can combine to control traffic from host port to wire port for BlueField 2 NIC.
The traffic flows from host to embedded ARM, then to the physical port.
The work flow is on the ARM system, configure available descriptor threshold to RX queue and enable avail_thresh-triggered flag in host shaper, after receiving available descriptor threshold event, delay a while until RX queue is empty , then disable the shaper. We recycle this work flow to reduce RX queue drops on ARM system.

Add new libethdev API to set available descriptor threshold, add rte event RTE_ETH_EVENT_RX_AVAIL_THRESH to handle available descriptor threshold event. For host shaper, because it doesn't align to existing DPDK framework and is specific to Nvidia NIC, use PMD private API.

For integration with testpmd, put the private cmdline function and available descriptor threshold event handler in mlx5 PMD directory by adding a new file mlx5_testpmd.c. Follow David Marchand's driver specific commands framework to add mlx5 specific commands.

Spike Du (6):
net/mlx5: add LWM support for Rxq
common/mlx5: share interrupt management
net/mlx5: add LWM event handling support
net/mlx5: support Rx queue based available descriptor threshold net/mlx5: add private API to config host port shaper app/testpmd: add Host Shaper command

 app/test-pmd/testpmd.c                       |   7 +
 doc/guides/nics/mlx5.rst                     |  93 +++++++++
 doc/guides/rel_notes/release_22_07.rst       |   2 +
 drivers/common/mlx5/linux/meson.build        |  13 ++
 drivers/common/mlx5/linux/mlx5_common_os.c   | 131 ++++++++++++
 drivers/common/mlx5/linux/mlx5_common_os.h   |  11 +
 drivers/common/mlx5/mlx5_prm.h               |  26 +++
 drivers/common/mlx5/version.map              |   2 +
 drivers/common/mlx5/windows/mlx5_common_os.h |  24 +++
 drivers/net/mlx5/linux/mlx5_ethdev_os.c      |  71 -------
 drivers/net/mlx5/linux/mlx5_os.c             | 132 +++---------
 drivers/net/mlx5/linux/mlx5_socket.c         |  53 +----
 drivers/net/mlx5/meson.build                 |   3 +
 drivers/net/mlx5/mlx5.c                      |  68 +++++++
 drivers/net/mlx5/mlx5.h                      |  12 +-
 drivers/net/mlx5/mlx5_devx.c                 |  60 +++++-
 drivers/net/mlx5/mlx5_devx.h                 |   1 +
 drivers/net/mlx5/mlx5_rx.c                   | 288 +++++++++++++++++++++++++++
 drivers/net/mlx5/mlx5_rx.h                   |  13 ++
 drivers/net/mlx5/mlx5_testpmd.c              | 205 +++++++++++++++++++
 drivers/net/mlx5/mlx5_testpmd.h              |  26 +++
 drivers/net/mlx5/mlx5_txpp.c                 |  28 +--
 drivers/net/mlx5/rte_pmd_mlx5.h              |  30 +++
 drivers/net/mlx5/version.map                 |   2 +
 drivers/net/mlx5/windows/mlx5_ethdev_os.c    |  22 --
 drivers/vdpa/mlx5/mlx5_vdpa_virtq.c          |  48 +----
 26 files changed, 1063 insertions(+), 308 deletions(-)
 create mode 100644 drivers/net/mlx5/mlx5_testpmd.c
 create mode 100644 drivers/net/mlx5/mlx5_testpmd.h
Signature · 1 line
1.8.3.1