Skip to content

arm: mvebu: turris_omnia: Fix hangup in debug UART

Pali Rohár u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5arm: Add new config option ARCH_VERY_EARLY_INITarch/arm/Kconfig arch/arm/lib/crt0.S+11 -01 reply
2/5arm: mvebu: Move internal registers in arch_very_early_init() functionarch/arm/mach-mvebu/Kconfig arch/arm/mach-mvebu/Makefile arch/arm/mach-mvebu/cpu.c +1 more+29 -3112 replies
3/5serial: Add new config option SPL_DEBUG_UART_BASEdrivers/serial/Kconfig+7 -01 reply
4/5serial: ns16550: Add support for SPL_DEBUG_UART_BASEdrivers/serial/ns16550.c+2 -21 reply
5/5arm: mvebu: turris_omnia: Fix DEBUG_UART_BASEconfigs/turris_omnia_defconfig+2 -14 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan Roese
SeriesR-b R-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] arm: mvebu: turris_omnia: Fix hangup in debug UART

If proper U-Boot on Turris Omnia tries to print something on debug UART then CPU hangs. Reason is that debug UART in proper U-Boot for Turris Omnia has incorrect configuration of base register. Base register is different in SPL and also in different stages of proper U-Boot.

Fix all these issues. Introduce new arch_very_early_init() ARM function which will be called at very early stage prior initialization of debug UART. Move code which moves internal mvebu registers to this function. And split configuration of DEBUG_UART_BASE into SPL and proper U-Boot to allow setting different values which matches current HW status.

With all these changes, it is possible call "printf" function in Turris Omnia's board_early_init_f() function in both SPL and proper U-Boot.

Pali Rohár (5):
arm: Add new config option ARCH_VERY_EARLY_INIT
arm: mvebu: Move internal registers in arch_very_early_init() function
serial: Add new config option SPL_DEBUG_UART_BASE
serial: ns16550: Add support for SPL_DEBUG_UART_BASE
arm: mvebu: turris_omnia: Fix DEBUG_UART_BASE

 arch/arm/Kconfig               |  6 ++++++
 arch/arm/lib/crt0.S            |  5 +++++
 arch/arm/mach-mvebu/Kconfig    |  1 +
 arch/arm/mach-mvebu/Makefile   |  1 +
 arch/arm/mach-mvebu/cpu.c      | 31 -------------------------------
 arch/arm/mach-mvebu/lowlevel.S | 27 +++++++++++++++++++++++++++
 configs/turris_omnia_defconfig |  3 ++-
 drivers/serial/Kconfig         |  7 +++++++
 drivers/serial/ns16550.c       |  4 ++--
 9 files changed, 51 insertions(+), 34 deletions(-)
 create mode 100644 arch/arm/mach-mvebu/lowlevel.S
Signature · 1 line
2.20.1