Skip to content

PCI: mvebu: Add support for PME and AER interrupts

Pali Rohár linux-arm-kernel linux-devicetree linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: irqchip: armada-370-xp: Update information about MPIC SoC ErrorDocumentation/devicetree/bindings/interrupt-controller/marvell,armada-370-xp-mpic.txt+9 -01 reply
2/6irqchip/armada-370-xp: Implement SoC Error interruptsdrivers/irqchip/irq-armada-370-xp.c+210 -310 replies
3/6ARM: dts: armada-38x.dtsi: Add node for MPIC SoC Error IRQ controllerarch/arm/boot/dts/armada-38x.dtsi+5 -00 replies
4/6dt-bindings: PCI: mvebu: Update information about summary interruptDocumentation/devicetree/bindings/pci/mvebu-pci.txt+1 -00 replies
5/6PCI: mvebu: Implement support for interrupts on emulated bridgedrivers/pci/controller/pci-mvebu.c+189 -190 replies
6/6ARM: dts: armada-385.dtsi: Add definitions for PCIe summary interruptsarch/arm/boot/dts/armada-385.dtsi+12 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] PCI: mvebu: Add support for PME and AER interrupts

mvebu PCIe PME and AER interrupts are reported via PCIe summary interrupt. PCIe summary interrupt is reported via mvebu MPIC SoC error summary interrupt. And MPIC SoC error summary interrupt is reported via MPIC IRQ 4.

This patch series implements support for interrupts in MPIC SoC error hierarchy in irq-armada-370-xp.c driver and support for interrupts in mvebu PCIe hierarchy in pci-mvebu.c.

Finally PCIe PME and AER interrupts are routed to the correct PCIe Root Port, which allows kernel PME and AER drivers to take care of them.

Tested on A385 board and kernel PME and AER drivers works correctly:

[    0.898482] pcieport 0000:00:01.0: PME: Signaling with IRQ 61
[    0.904422] pcieport 0000:00:01.0: AER: enabled with IRQ 61
[    0.910113] pcieport 0000:00:02.0: enabling device (0140 -> 0142)
[    0.916299] pcieport 0000:00:02.0: PME: Signaling with IRQ 62
[    0.922216] pcieport 0000:00:02.0: AER: enabled with IRQ 62
[    0.927917] pcieport 0000:00:03.0: enabling device (0140 -> 0142)
[    0.934090] pcieport 0000:00:03.0: PME: Signaling with IRQ 63
[    0.940006] pcieport 0000:00:03.0: AER: enabled with IRQ 63

This change finally allows to debug PCIe issues on A385 boards.

Pali Rohár (6):
dt-bindings: irqchip: armada-370-xp: Update information about MPIC SoC
Error
irqchip/armada-370-xp: Implement SoC Error interrupts
ARM: dts: armada-38x.dtsi: Add node for MPIC SoC Error IRQ controller
dt-bindings: PCI: mvebu: Update information about summary interrupt
PCI: mvebu: Implement support for interrupts on emulated bridge
ARM: dts: armada-385.dtsi: Add definitions for PCIe summary interrupts

 .../marvell,armada-370-xp-mpic.txt            |   9 +
 .../devicetree/bindings/pci/mvebu-pci.txt     |   1 +
 arch/arm/boot/dts/armada-385.dtsi             |  20 +-
 arch/arm/boot/dts/armada-38x.dtsi             |   5 +
 drivers/irqchip/irq-armada-370-xp.c           | 213 +++++++++++++++++-
 drivers/pci/controller/pci-mvebu.c            | 208 +++++++++++++++--
 6 files changed, 426 insertions(+), 30 deletions(-)
Signature · 1 line
2.20.1