Skip to content

Revert metric hybrid events, fix tools events

Ian Rogers linux-perf-users lkml 1 version Applied

Status from this message: I picked this from the cover letter and added to this revert, to justify

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5Revert "perf stat: Support metrics with hybrid events"tools/perf/util/metricgroup.c tools/perf/util/stat-display.c+22 -24910 replies
2/5perf evsel: Constify a few arraystools/perf/tests/evsel-roundtrip-name.c tools/perf/util/evsel.c tools/perf/util/evsel.h +1 more+14 -150 replies
3/5perf evsel: Add tool event helperstools/perf/util/evsel.c tools/perf/util/evsel.h+42 -101 reply
4/5perf metrics: Support all tool eventstools/perf/util/metricgroup.c tools/perf/util/stat-shadow.c+75 -390 replies
5/5perf metrics: Don't add all tool events for sharingtools/perf/util/metricgroup.c+39 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Revert metric hybrid events, fix tools events

Hybrid metrics place a PMU at the end of the parse string. This is also where tool events are placed. The behavior of the parse string isn't clear and so revert the change for now.

commit 75eafc970bd9 ("perf list: Print all available tool events") had an off-by-1 error. Try to separate the tool event enum logic from evsels. Also add a for loop helper to simplify working with a variety of tool events.

Add support to metrics for more tool events than just duration_time. Make the sharing logic only look to add for sharing potentially used tool events, found by scanning the list of metrics.

Ian Rogers (5):
Revert "perf stat: Support metrics with hybrid events" perf evsel: Constify a few arrays
perf evsel: Add tool event helpers
perf metrics: Support all tool events
perf metrics: Don't add all tool events for sharing

 tools/perf/tests/evsel-roundtrip-name.c |   2 +-
 tools/perf/util/evsel.c                 |  53 +++-
 tools/perf/util/evsel.h                 |  22 +-
 tools/perf/util/metricgroup.c           | 373 +++++++-----------------
 tools/perf/util/parse-events.c          |   2 +-
 tools/perf/util/stat-display.c          |   8 +-
 tools/perf/util/stat-shadow.c           |  27 +-
 7 files changed, 180 insertions(+), 307 deletions(-)
Signature · 1 line
2.36.0.512.ge40c2bad7a-goog