Skip to content

PIIX3-IDE XEN cleanup

Bernhard Beschow qemu-devel qemu-trivial xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* Have pci_xen_ide_unplug() return void (Paul Durrant)
* CC Xen maintainers (Michael S. Tsirkin)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/ide/piix: Remove redundant "piix3-ide-xen" device classhw/i386/pc_piix.c hw/ide/piix.c+1 -91 reply
2/3hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug()hw/ide/piix.c+11 -01 reply
3/3include/hw/ide: Unexport pci_piix3_xen_ide_unplug()hw/i386/xen/xen_platform.c hw/ide/piix.c include/hw/ide.h+47 -502 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPaul DurrantAnthony PERARDPhilippe Mathieu-Daudé
1/3R-b
2/3R-b
3/3R-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] PIIX3-IDE XEN cleanup

v2:
* Have pci_xen_ide_unplug() return void (Paul Durrant)
* CC Xen maintainers (Michael S. Tsirkin)

v1:
This patch series first removes the redundant "piix3-ide-xen" device class and then moves a XEN-specific helper function from PIIX3 code to XEN code. The idea is to decouple PIIX3-IDE and XEN and to compile XEN-specific bits only if XEN support is enabled.

Testing done:
'qemu-system-x86_64 -M pc -m 1G -cdrom archlinux-2022.05.01-x86_64.iso" boots successfully and a 'poweroff' inside the VM also shuts it down correctly.

XEN mode wasn't tested for the time being since its setup procedure seems quite sophisticated. Please let me know in case this is an obstacle.

Bernhard Beschow (3):
hw/ide/piix: Remove redundant "piix3-ide-xen" device class hw/ide/piix: Add some documentation to pci_piix3_xen_ide_unplug() include/hw/ide: Unexport pci_piix3_xen_ide_unplug()

 hw/i386/pc_piix.c          |  3 +--
 hw/i386/xen/xen_platform.c | 48 +++++++++++++++++++++++++++++++++++++-
 hw/ide/piix.c              | 42 ---------------------------------
 include/hw/ide.h           |  3 ---
 4 files changed, 48 insertions(+), 48 deletions(-)
Signature · 1 line
2.36.1